* Re: xfs: recovery of swap extents operations for CRC filesystems
2013-09-11 21:18 xfs: recovery of swap extents operations for CRC filesystems Dan Carpenter
@ 2013-09-11 2:19 ` Dave Chinner
2013-09-11 22:44 ` Mark Tinguely
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2013-09-11 2:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: mtinguely, xfs
On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
> Hello Dave Chinner,
>
> The patch 638f44163d57: "xfs: recovery of swap extents operations for
> CRC filesystems" from Aug 30, 2013, leads to the following
> static checker warning: "fs/xfs/xfs_log_recover.c:2999
> xlog_recover_inode_pass2()
> info: ignoring unreachable code."
>
> fs/xfs/xfs_log_recover.c
> 2992 out_release:
> 2993 xfs_buf_relse(bp);
> 2994 error:
> 2995 if (need_free)
> 2996 kmem_free(in_f);
> 2997 return XFS_ERROR(error);
> ^^^^^^^^^^^^^^^^^^^^^^^
> 2998
> 2999 xfs_buf_relse(bp);
> 3000 goto error;
>
> These two added lines are unreachable. Sometimes people add dead code
> for later, so this might be intentional. It's not clear.
It's dead code. I reworked the error handling of the function and
didn't clean up all the mess.
Mark, I'm away from my upstream dev environment until next week -
can you send a followup patch to fix this?
Cheers,
Dave.
--
Dave Chinner
dchinner@redhat.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* re: xfs: recovery of swap extents operations for CRC filesystems
@ 2013-09-11 21:18 Dan Carpenter
2013-09-11 2:19 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-09-11 21:18 UTC (permalink / raw)
To: dchinner; +Cc: xfs
Hello Dave Chinner,
The patch 638f44163d57: "xfs: recovery of swap extents operations for
CRC filesystems" from Aug 30, 2013, leads to the following
static checker warning: "fs/xfs/xfs_log_recover.c:2999
xlog_recover_inode_pass2()
info: ignoring unreachable code."
fs/xfs/xfs_log_recover.c
2992 out_release:
2993 xfs_buf_relse(bp);
2994 error:
2995 if (need_free)
2996 kmem_free(in_f);
2997 return XFS_ERROR(error);
^^^^^^^^^^^^^^^^^^^^^^^
2998
2999 xfs_buf_relse(bp);
3000 goto error;
These two added lines are unreachable. Sometimes people add dead code
for later, so this might be intentional. It's not clear.
3001 }
regards,
dan carpenter
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xfs: recovery of swap extents operations for CRC filesystems
2013-09-11 2:19 ` Dave Chinner
@ 2013-09-11 22:44 ` Mark Tinguely
0 siblings, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2013-09-11 22:44 UTC (permalink / raw)
To: Dave Chinner; +Cc: tinguely, Dan Carpenter, xfs
On 09/10/13 21:19, Dave Chinner wrote:
> On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
>> Hello Dave Chinner,
>>
>> The patch 638f44163d57: "xfs: recovery of swap extents operations for
>> CRC filesystems" from Aug 30, 2013, leads to the following
>> static checker warning: "fs/xfs/xfs_log_recover.c:2999
>> xlog_recover_inode_pass2()
>> info: ignoring unreachable code."
>>
>> fs/xfs/xfs_log_recover.c
>> 2992 out_release:
>> 2993 xfs_buf_relse(bp);
>> 2994 error:
>> 2995 if (need_free)
>> 2996 kmem_free(in_f);
>> 2997 return XFS_ERROR(error);
>> ^^^^^^^^^^^^^^^^^^^^^^^
>> 2998
>> 2999 xfs_buf_relse(bp);
>> 3000 goto error;
>>
>> These two added lines are unreachable. Sometimes people add dead code
>> for later, so this might be intentional. It's not clear.
>
> It's dead code. I reworked the error handling of the function and
> didn't clean up all the mess.
>
> Mark, I'm away from my upstream dev environment until next week -
> can you send a followup patch to fix this?
>
> Cheers,
>
> Dave.
sure. I should have caught it in review.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-11 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 21:18 xfs: recovery of swap extents operations for CRC filesystems Dan Carpenter
2013-09-11 2:19 ` Dave Chinner
2013-09-11 22:44 ` Mark Tinguely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox