From: Mark Tinguely <tinguely@sgi.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: xfs directory unbalance assert test
Date: Tue, 17 Sep 2013 10:48:46 -0500 [thread overview]
Message-ID: <523879DE.1020302@sgi.com> (raw)
In-Reply-To: <20130917152852.GA9550@dhcp-13-216.nay.redhat.com>
On 09/17/13 10:28, Eryu Guan wrote:
> On Tue, Sep 17, 2013 at 09:59:47AM -0500, Mark Tinguely wrote:
...
>> +_scratch_unmount> /dev/null 2>&1
>
> This is not necessary, _require_scratch has done the unmount work.
okay, stole that from other tests.
>
>> +_scratch_mkfs_sized 11g>> $seqres.full 2>&1
>
> _scratch_mkfs_sized expects fssize in bytes, 11g is not a valid value
> The comments in common/rc about _scratch_mkfs_sized say
>
> # _scratch_mkfs_sized<size in bytes> [optional blocksize]
That was a shortcut for xfs. Looking in common/rc. I see that it breaks
the other filesystems that need the size in blocks.
...
>> @@ -0,0 +1,2 @@
>> +QA output created by 319
>> +--- silence is golden ---
>> Index: b/tests/generic/group
>> ===================================================================
>> --- a/tests/generic/group
>> +++ b/tests/generic/group
>> @@ -121,3 +121,4 @@
>> 316 auto quick
>> 317 auto metadata quick
>> 318 acl attr auto quick
>> +319 stress
>
> Should be in auto group too I guess.
It takes a very long time to run to completion, don't know if people
want this in the auto run.
> Thanks,
> Eryu Guan
Thanks for the feedback
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-17 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130917145946.124195107@sgi.com>
2013-09-17 14:59 ` [PATCH] xfstests: xfs directory unbalance assert test Mark Tinguely
2013-09-17 15:28 ` Eryu Guan
2013-09-17 15:48 ` Mark Tinguely [this message]
2013-09-17 15:51 ` Eric Sandeen
2013-09-17 16:00 ` Mark Tinguely
2013-09-17 15:41 ` Eric Sandeen
2013-09-17 15:58 ` Mark Tinguely
2013-09-17 16:06 ` Eric Sandeen
2013-09-17 21:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523879DE.1020302@sgi.com \
--to=tinguely@sgi.com \
--cc=guaneryu@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox