From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111])
	by oss.sgi.com (Postfix) with ESMTP id 666317F50
	for <xfs@oss.sgi.com>; Tue, 17 Sep 2013 10:48:46 -0500 (CDT)
Message-ID: <523879DE.1020302@sgi.com>
Date: Tue, 17 Sep 2013 10:48:46 -0500
From: Mark Tinguely <tinguely@sgi.com>
MIME-Version: 1.0
Subject: Re: [PATCH] xfstests: xfs directory unbalance assert test
References: <20130917145946.124195107@sgi.com>
	<20130917145959.333796933@sgi.com>
	<20130917152852.GA9550@dhcp-13-216.nay.redhat.com>
In-Reply-To: <20130917152852.GA9550@dhcp-13-216.nay.redhat.com>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: xfs-bounces@oss.sgi.com
Sender: xfs-bounces@oss.sgi.com
To: Eryu Guan <guaneryu@gmail.com>
Cc: xfs@oss.sgi.com

On 09/17/13 10:28, Eryu Guan wrote:
> On Tue, Sep 17, 2013 at 09:59:47AM -0500, Mark Tinguely wrote:
...

>> +_scratch_unmount>  /dev/null 2>&1
>
> This is not necessary, _require_scratch has done the unmount work.

okay, stole that from other tests.

>
>> +_scratch_mkfs_sized 11g>>  $seqres.full 2>&1
>
> _scratch_mkfs_sized expects fssize in bytes, 11g is not a valid value
> The comments in common/rc about _scratch_mkfs_sized say
>
> # _scratch_mkfs_sized<size in bytes>  [optional blocksize]

That was a shortcut for xfs. Looking in common/rc. I see that it breaks 
the other filesystems that need the size in blocks.

...

>> @@ -0,0 +1,2 @@
>> +QA output created by 319
>> +--- silence is golden ---
>> Index: b/tests/generic/group
>> ===================================================================
>> --- a/tests/generic/group
>> +++ b/tests/generic/group
>> @@ -121,3 +121,4 @@
>>   316 auto quick
>>   317 auto metadata quick
>>   318 acl attr auto quick
>> +319 stress
>
> Should be in auto group too I guess.

It takes a very long time to run to completion, don't know if people 
want this in the auto run.

> Thanks,
> Eryu Guan

Thanks for the feedback

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs