From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: Mark Tinguely <tinguely@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: v2 xfs directory unbalance assert test
Date: Tue, 17 Sep 2013 16:35:46 -0500 [thread overview]
Message-ID: <5238CB32.2090404@sandeen.net> (raw)
In-Reply-To: <20130917213409.GL19103@dastard>
On 9/17/13 4:34 PM, Dave Chinner wrote:
> On Tue, Sep 17, 2013 at 02:25:23PM -0500, Mark Tinguely wrote:
>> This tests triggers an assert in the XFS directory unbalance code.
>> This test originally written by Brian Foster and suggestions
>> from Micheal Semon.
>>
>> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
>> ---
>> v1->v2:
>> remove clean up.
>> remove $seqres.full before test.
>> remove scratch mount.
>> 11g -> calculate 11g bytes.
>> check for failing mkfs and mount.
>> add a safer removal of the scratch files.
>>
>> put into auto group and "long" group so people can opt out:
>> this test almost an hour on my test box.
>
> 45m is too long for the auto group. The entire auto group runs in
> 50-55 minutes on my test VMs, so doubling that for one test is not
> really a good idea.
Ok, sorry, my fault. Fix on commit?
-Eric
> The usual rule of thumb for the auto group is that the test should
> take less than 5 minutes to run. For the quick group, it should take
> less than 30-60s to run.
>
> If you want to make this test run in the auto group, scale it for
> stress tests via the use of LOAD_FACTOR and TIME_FACTOR, and add it
> to the stress group.
>
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-17 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 19:25 [PATCH] xfstests: v2 xfs directory unbalance assert test Mark Tinguely
2013-09-17 19:37 ` Eric Sandeen
2013-09-17 20:03 ` Mark Tinguely
2013-09-17 21:34 ` Dave Chinner
2013-09-17 21:35 ` Eric Sandeen [this message]
2013-09-17 22:14 ` Mark Tinguely
2013-09-18 16:36 ` Michael L. Semon
2013-09-18 17:43 ` Mark Tinguely
2013-09-23 23:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5238CB32.2090404@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox