Re: [PATCH] xfstests: v2 xfs directory unbalance assert test

Eric Sandeen
2013-09-17T21:35:48Z

On 9/17/13 4:34 PM, Dave Chinner wrote:
> On Tue, Sep 17, 2013 at 02:25:23PM -0500, Mark Tinguely wrote:
>> This tests triggers an assert in the XFS directory unbalance code.
>> This test originally written by Brian Foster and suggestions
>> from Micheal Semon.
>>
>> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
>> ---
>> v1->v2:
>> remove clean up.
>> remove $seqres.full before test.
>> remove scratch mount.
>> 11g -> calculate 11g bytes.
>> check for failing mkfs and mount.
>> add a safer removal of the scratch files.
>>
>> put into auto group and "long" group so people can opt out:
>> this test almost an hour on my test box.
>
> 45m is too long for the auto group. The entire auto group runs in
> 50-55 minutes on my test VMs, so doubling that for one test is not
> really a good idea.

Ok, sorry, my fault. Fix on commit?

-Eric

> The usual rule of thumb for the auto group is that the test should
> take less than 5 minutes to run. For the quick group, it should take
> less than 30-60s to run.
>
> If you want to make this test run in the auto group, scale it for
> stress tests via the use of LOAD_FACTOR and TIME_FACTOR, and add it
> to the stress group.
>
> Cheers,
>
> Dave.