public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfsprogs: initialize filetype for xfs_name_dot
@ 2013-09-17 16:56 Eric Sandeen
  2013-09-18 20:36 ` Mark Tinguely
  2013-10-18 16:33 ` Rich Johnston
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2013-09-17 16:56 UTC (permalink / raw)
  To: 'linux-xfs@oss.sgi.com'

If we add the '.' entry in repair, make sure it has a file type
initialized.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/repair/phase6.c b/repair/phase6.c
index a4ad7a3..580dbf7 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -34,7 +34,9 @@ static struct cred		zerocr;
 static struct fsxattr 		zerofsx;
 static xfs_ino_t		orphanage_ino;
 
-static struct xfs_name		xfs_name_dot = {(unsigned char *)".", 1};
+static struct xfs_name		xfs_name_dot = {(unsigned char *)".",
+						1,
+						XFS_DIR3_FT_DIR};
 
 /*
  * Data structures used to keep track of directories where the ".."

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsprogs: initialize filetype for xfs_name_dot
  2013-09-17 16:56 [PATCH] xfsprogs: initialize filetype for xfs_name_dot Eric Sandeen
@ 2013-09-18 20:36 ` Mark Tinguely
  2013-10-18 16:33 ` Rich Johnston
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2013-09-18 20:36 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: 'linux-xfs@oss.sgi.com'

On 09/17/13 11:56, Eric Sandeen wrote:
> If we add the '.' entry in repair, make sure it has a file type
> initialized.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---

This looks good.

looks like shared code xfs_dir_lookup() returns the ci match in a 
xfs_name without a file type. Not used now, but may be handy.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsprogs: initialize filetype for xfs_name_dot
  2013-09-17 16:56 [PATCH] xfsprogs: initialize filetype for xfs_name_dot Eric Sandeen
  2013-09-18 20:36 ` Mark Tinguely
@ 2013-10-18 16:33 ` Rich Johnston
  1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-10-18 16:33 UTC (permalink / raw)
  To: Eric Sandeen, 'linux-xfs@oss.sgi.com'

This has been committed.

Thanks
--Rich

commit 1acc538540ce22e16bb55ca573691070a8d375db
Author: Eric Sandeen <sandeen@redhat.com>
Date:   Tue Sep 17 16:56:59 2013 +0000

     xfsprogs: initialize filetype for xfs_name_dot

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-18 16:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 16:56 [PATCH] xfsprogs: initialize filetype for xfs_name_dot Eric Sandeen
2013-09-18 20:36 ` Mark Tinguely
2013-10-18 16:33 ` Rich Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox