From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 01A5D7F37 for ; Fri, 20 Sep 2013 08:20:43 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 85324AC002 for ; Fri, 20 Sep 2013 06:20:39 -0700 (PDT) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id xN1TAgxq6RgHfjZo (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 20 Sep 2013 06:20:38 -0700 (PDT) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8KDKa20016585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Sep 2013 13:20:37 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8KDKZGL020924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 20 Sep 2013 13:20:36 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8KDKZah017066 for ; Fri, 20 Sep 2013 13:20:35 GMT Message-ID: <523C4BD0.7040309@oracle.com> Date: Fri, 20 Sep 2013 21:21:20 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: [PATCH] xfs: improve xfs_iext_destroy() by freeing extent indirection array directly List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "xfs@oss.sgi.com" From: Jie Liu To free the incore file extents stores at the indirection array, we call the common routine xfs_iext_irec_remove() to remove a record from the array one at a time in reverse order, which will resize an extent indirection array repeatedly according to the array size. This is not often the case to make a file with thousands extent records stores at an indirection array, but above operation is inefficient and could result in memory fragments. This patch refine xfs_iext_destroy() by freeing the extent records from the indirection array directly in this case. Signed-off-by: Jie Liu --- fs/xfs/xfs_inode_fork.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_inode_fork.c b/fs/xfs/xfs_inode_fork.c index 02f1083..ba70f98 100644 --- a/fs/xfs/xfs_inode_fork.c +++ b/fs/xfs/xfs_inode_fork.c @@ -1525,9 +1525,12 @@ xfs_iext_destroy( int nlists; nlists = ifp->if_real_bytes / XFS_IEXT_BUFSZ; - for (erp_idx = nlists - 1; erp_idx >= 0 ; erp_idx--) { - xfs_iext_irec_remove(ifp, erp_idx); + for (erp_idex = 0; erp_idx < nlists; erp_idx++) { + xfs_ext_irec_t *erp = &ifp->if_u1.if_ext_irec[erp_idx]; + if (erp->er_extbuf) + kmem_free(erp->er_extbuf); } + kmem_free(ifp->if_u1.if_ext_irec); ifp->if_flags &= ~XFS_IFEXTIREC; } else if (ifp->if_real_bytes) { kmem_free(ifp->if_u1.if_extents); -- 1.7.9.5 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs