From: Mark Tinguely <tinguely@sgi.com>
To: "Michael L. Semon" <mlsemon35@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix node forward in xfs_node_toosmall
Date: Mon, 23 Sep 2013 16:45:31 -0500 [thread overview]
Message-ID: <5240B67B.3000305@sgi.com> (raw)
In-Reply-To: <5240B3F1.4040305@gmail.com>
On 09/23/13 16:34, Michael L. Semon wrote:
> On 09/20/2013 06:05 PM, Mark Tinguely wrote:
>> Commit f5ea1100 cleans up the disk to host conversions for
>> node directory entries, but because a variable is reused in
>> xfs_node_toosmall() the next node is not correctly found.
>> If the original node is small enough (<= 3/8 of the node size),
>> this change may incorrectly cause a node collapse when it should
>> not. That will cause an assert in xfstest generic/319:
>>
>> Assertion failed: first<= last&& last< BBTOB(bp->b_length),
>> file: /root/newest/xfs/fs/xfs/xfs_trans_buf.c, line: 569
>>
>> Keep the original node header to get the correct forward node.
>
> This works for xfstests generic/319 on 32-bit x86. The xfstests
> run was okay, with a lockdep in the middle and a crash in xfs/300.
> Neither the lockdep nor the crash could reproduced by running
> individual tests one by one.
>
> generic/319 itself fails only because it couldn't find its
> _cleanup routine. I'm not sure if I'm using v1 or v2 of
> generic/319.
>
> The kernel is set to the commit just before the latest aio-next
> merge, which is causing severe problems here. xfsprogs was the
> latest production xfsprogs because my copy of xfstests is having
> trouble checking v4 XFS filesystems otherwise.
>
> Will test xfs_node_toosmall patch v2 once I get home.
>
> Thanks!
>
> Michael
>
319 v1 had the cleanup and removed in v2 because of feedback.
IMO, it should be there even basically empty.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-23 21:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 22:05 [PATCH] xfs: fix node forward in xfs_node_toosmall Mark Tinguely
2013-09-23 0:08 ` Dave Chinner
2013-09-23 13:38 ` Mark Tinguely
2013-09-23 17:18 ` [PATCH] xfs: v2 " Mark Tinguely
2013-09-23 23:48 ` Dave Chinner
2013-09-24 17:35 ` Mark Tinguely
2013-09-24 18:59 ` Ben Myers
2013-09-24 21:06 ` Dave Chinner
2013-09-24 21:34 ` Mark Tinguely
2013-09-24 23:33 ` Dave Chinner
2013-09-25 18:38 ` Ben Myers
2013-09-25 21:03 ` Eric Sandeen
2013-09-25 22:11 ` Ben Myers
2013-09-23 21:34 ` [PATCH] xfs: " Michael L. Semon
2013-09-23 21:45 ` Mark Tinguely [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-09 0:09 Ben Myers
2013-10-10 23:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5240B67B.3000305@sgi.com \
--to=tinguely@sgi.com \
--cc=mlsemon35@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox