From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] [RFC] xfs: lookaside cache for xfs_buf_find
Date: Tue, 24 Sep 2013 12:41:54 -0500 [thread overview]
Message-ID: <5241CEE2.5040607@sgi.com> (raw)
In-Reply-To: <20130924004803.GZ9901@dastard>
On 09/23/13 19:48, Dave Chinner wrote:
> On Mon, Sep 23, 2013 at 09:17:35AM -0500, Mark Tinguely wrote:
>> On 09/08/13 20:33, Dave Chinner wrote:
>>> From: Dave Chinner<dchinner@redhat.com>
>>>
>>> CPU overhead of buffer lookups dominate most metadata intensive
>>> workloads. The thing is, most such workloads are hitting a
>>> relatively small number of buffers repeatedly, and so caching
>>> recently hit buffers is a good idea.
>>>
>> ...
>>
>> I think this needs more testing.
>
> Yes, that's what an "RFC" implies. It's an idea, it's not
> fully baked and it's not ready for inclusion - it's a proof of
> concept that needs further work, and I't being posted for discussion
> to determine if it's worth pursuing further.
>
> Indeed, I haven't proposed it for inclusion yet because I'm
> still finding problems caused by the patch - it's still just a
> prototype at this point.
>
>> I got the same panic running xfstest 319 with the patch at:
>> http://oss.sgi.com/archives/xfs/2013-09/msg00578.html
>> once it hung on a xfs_buf lock before the panic.
>>
>> And these are the only tests that I threw at this patch.
>
> Sure. The version I have in my stack at the moment has some more
> ixes in it, like handling of length mismatches due to stale buffers
> on lookaside lookups, and other such things.
>
> i.e. early feedback on prototype code is exactly what [RFC] patches
> are for...
And early feedback is that it has potential but needs more work.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-09-24 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 1:33 [PATCH] [RFC] xfs: lookaside cache for xfs_buf_find Dave Chinner
2013-09-09 15:17 ` Mark Tinguely
2013-09-09 15:39 ` Dave Chinner
2013-09-18 21:48 ` Mark Tinguely
2013-09-18 23:24 ` Dave Chinner
2013-09-19 13:23 ` Mark Tinguely
2013-09-23 14:17 ` Mark Tinguely
2013-09-23 21:25 ` Michael L. Semon
2013-09-24 0:48 ` Dave Chinner
2013-09-24 17:41 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241CEE2.5040607@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox