From: Eric Sandeen <sandeen@sandeen.net>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] misc kernel leak patches
Date: Wed, 02 Oct 2013 15:54:04 -0500 [thread overview]
Message-ID: <524C87EC.7070909@sandeen.net> (raw)
In-Reply-To: <20131002125110.745269864@sgi.com>
On 10/2/13 7:51 AM, Mark Tinguely wrote:
> Here are a couple patches to free leaked memory.
>
> First patch is v2 of a Coverity found leak in xfs_dir2_node_removename().
>
> Second patch arose from an eariler leak found by Coverity. In looking
> at that patch, Eric noted that it appeared that the transaction's
> item list is also leaked if recovery fails. I tested this patch by forcing
> errors into the recovery code to verify that the items are now being released.
>
> I will send patches for xfsprogs equivalent.
Good plan w.r.t. kernel first, progs 2nd, I think. Makes it less likely
to accidentally send a free(); or similar upstream. :)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-10-02 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 12:51 [PATCH 0/2] misc kernel leak patches Mark Tinguely
2013-10-02 12:51 ` [PATCH 1/2] xfs: fix memory leak in xfs_dir2_node_removename Mark Tinguely
2013-10-02 20:32 ` Dave Chinner
2013-10-02 21:04 ` Mark Tinguely
2013-10-02 12:51 ` [PATCH 2/2] xfs free the list of recovery items on error Mark Tinguely
2013-12-04 20:51 ` Ben Myers
2013-12-05 22:52 ` Ben Myers
2013-10-02 20:54 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524C87EC.7070909@sandeen.net \
--to=sandeen@sandeen.net \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox