From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: mkfs scratch device in generic/294
Date: Sun, 06 Oct 2013 15:42:31 -0500 [thread overview]
Message-ID: <5251CB37.2040406@redhat.com> (raw)
test 294 is using the scratch device w/o mkfs-ing it first,
this runs the risk of following a test which completely
fills the fs, causing 294 to fail.
add "rm -f $seqres.full" as well, it was growing on every run.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/generic/294 b/tests/generic/294
index fa7f339..3fa6ba2 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -48,6 +48,9 @@ _supported_fs generic
_supported_os Linux
_require_scratch
+rm -f $seqres.full
+_scratch_mkfs > $seqres.full 2>&1 || _fail "Could not mkfs scratch device"
+
THIS_TEST_DIR=$SCRATCH_MNT/$seq.test
_create_files()
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-10-06 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 20:42 Eric Sandeen [this message]
2013-10-09 21:41 ` [PATCH] xfstests: mkfs scratch device in generic/294 Dave Chinner
2013-10-16 20:28 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5251CB37.2040406@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox