* [PATCH] xfstests: mkfs scratch device in generic/294 @ 2013-10-06 20:42 Eric Sandeen 2013-10-09 21:41 ` Dave Chinner 2013-10-16 20:28 ` Rich Johnston 0 siblings, 2 replies; 3+ messages in thread From: Eric Sandeen @ 2013-10-06 20:42 UTC (permalink / raw) To: xfs-oss test 294 is using the scratch device w/o mkfs-ing it first, this runs the risk of following a test which completely fills the fs, causing 294 to fail. add "rm -f $seqres.full" as well, it was growing on every run. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- diff --git a/tests/generic/294 b/tests/generic/294 index fa7f339..3fa6ba2 100755 --- a/tests/generic/294 +++ b/tests/generic/294 @@ -48,6 +48,9 @@ _supported_fs generic _supported_os Linux _require_scratch +rm -f $seqres.full +_scratch_mkfs > $seqres.full 2>&1 || _fail "Could not mkfs scratch device" + THIS_TEST_DIR=$SCRATCH_MNT/$seq.test _create_files() _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: mkfs scratch device in generic/294 2013-10-06 20:42 [PATCH] xfstests: mkfs scratch device in generic/294 Eric Sandeen @ 2013-10-09 21:41 ` Dave Chinner 2013-10-16 20:28 ` Rich Johnston 1 sibling, 0 replies; 3+ messages in thread From: Dave Chinner @ 2013-10-09 21:41 UTC (permalink / raw) To: Eric Sandeen; +Cc: xfs-oss On Sun, Oct 06, 2013 at 03:42:31PM -0500, Eric Sandeen wrote: > test 294 is using the scratch device w/o mkfs-ing it first, > this runs the risk of following a test which completely > fills the fs, causing 294 to fail. > > add "rm -f $seqres.full" as well, it was growing on every run. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> *nod* Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: mkfs scratch device in generic/294 2013-10-06 20:42 [PATCH] xfstests: mkfs scratch device in generic/294 Eric Sandeen 2013-10-09 21:41 ` Dave Chinner @ 2013-10-16 20:28 ` Rich Johnston 1 sibling, 0 replies; 3+ messages in thread From: Rich Johnston @ 2013-10-16 20:28 UTC (permalink / raw) To: Eric Sandeen, xfs-oss This has been committed. Thanks --Rich commit bd7fd0db645a8fc54564787287eabb0c21ea3787 Author: Eric Sandeen <sandeen@redhat.com> Date: Sun Oct 6 20:42:31 2013 +0000 xfstests: mkfs scratch device in generic/294 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-16 20:28 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-06 20:42 [PATCH] xfstests: mkfs scratch device in generic/294 Eric Sandeen 2013-10-09 21:41 ` Dave Chinner 2013-10-16 20:28 ` Rich Johnston
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox