Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore

Rich Johnston
2013-10-08T14:21:12Z

On 10/07/2013 07:57 PM, Eric Sandeen wrote:
> On 10/7/13 7:53 PM, Dave Chinner wrote:
>> Two tests, please. move all the common parts into common/dump, and
>> write them as two separate tests. That way we can easily track what
>> test is failing just by looking at what harness test is failing...
>
> I'm not quite convinced that it's 2 separate tests, TBH.
>
> It's the same root cause; I guess there is a slightly different
> outcome because if you hit the same root cause enough times,
> you'll segfault.

Multiple DMF offline files are successfully restored but the attrs are
lost. I wanted to show/test that case.

I agree with Eric that it is the same root cause but because can occur
with successful dumps and does not segfault, Thats why the 2 tests.

> That's the only difference in test #2.
> (and the segfault isn't fixed AFAIK).

Agreed and I will note that in the test description.

>
> -Eric