From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix inadvertent mkfs default change for projid32bit
Date: Mon, 07 Oct 2013 19:46:34 -0500 [thread overview]
Message-ID: <525355EA.9080100@sandeen.net> (raw)
In-Reply-To: <20131008003713.GQ4446@dastard>
On 10/7/13 7:37 PM, Dave Chinner wrote:
> On Sun, Oct 06, 2013 at 03:07:20PM -0500, Eric Sandeen wrote:
>> This commit:
>>
>> f3edb66a mkfs.xfs: validate options for CRCs up front.
>>
>> seems to have inadvertently switched to 32bit project IDs by default:
>>
>> - int projid32bit;
>> + int projid16bit;
>> ...
>> - projid32bit = 0;
>> + projid16bit = 0;
>>
>> Switch back to 16 bit project ID by default, at least until we
>> intentionally make that change.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
>> index eafbed3..ebab09d 100644
>> --- a/mkfs/xfs_mkfs.c
>> +++ b/mkfs/xfs_mkfs.c
>> @@ -965,7 +965,7 @@ main(
>> textdomain(PACKAGE);
>>
>> attrversion = 2;
>> - projid16bit = 0;
>> + projid16bit = 1;
>> blflag = bsflag = slflag = ssflag = lslflag = lssflag = 0;
>> blocklog = blocksize = 0;
>> sectorlog = lsectorlog = XFS_MIN_SECTORSIZE_LOG;
>
> And so:
>
> /* 32 bit project quota always on */
> /* attr2 always on */
> if (projid16bit == 1) {
> fprintf(stderr,
> _("32 bit Project IDs always enabled on CRC enabled filesytems\n"));
> usage();
> }
>
> That will prevent mkfs from making a CRC enabled filesystem.
Well, that's quite fixable.
> And, realistically, what's the problem with enabling 32 bit project
> IDs by default for all new filesystems in 3.2.0? I'm of the opinion
> we should just leave the code as it is because all kernels since
> 2.6.37 support 32 bit projid and any kernel picking up
> xfsprogs-3.2.0 when it is released will have a kernel that supports
> it....
Doesn't really bother me -
But please send a man page patch. ;)
And then we need to fix up xfstests... at least one fails as a result of
this IIRC, I'll have to go look again.
I don't care if the defaults change but I'd prefer it to not
have happened accidentally via
"mkfs.xfs: validate options for CRCs up front" ;)
It wasn't documented & didn't seem intentional, so it needs
fixing one way or the other.
-Eric
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-08 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 20:07 [PATCH] xfsprogs: fix inadvertent mkfs default change for projid32bit Eric Sandeen
2013-10-08 0:37 ` Dave Chinner
2013-10-08 0:46 ` Eric Sandeen [this message]
2013-10-08 0:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525355EA.9080100@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox