From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] block: clarify that bio_add_page() and related helpers can add multi pages
Date: Thu, 28 Mar 2019 08:21:55 -0600 [thread overview]
Message-ID: <5258cad3-b324-660f-589f-73eb7fb8fa04@kernel.dk> (raw)
In-Reply-To: <20190328035001.26276-1-ming.lei@redhat.com>
On 3/27/19 9:50 PM, Ming Lei wrote:
> bio_add_page() and __bio_add_page() are capable of adding pages into
> bio, and now we have at least two such usages alreay:
>
> - __bio_iov_bvec_add_pages()
> - nvmet_bdev_execute_rw().
>
> So update comments on these two helpers.
>
> The thing is a bit special for __bio_try_merge_page(), given the caller
> needs to know if the new added page is same with the last added page,
> then it isn't safe to pass multi-page in case that 'same_page' is true,
> so adds warning on potential misuse, and updates comment on
> __bio_try_merge_page().
This is going to create a needless conflict between 5.1 and the 5.2
block tree. I haven't pushed the 5.2 tree out yet, plan to do so
this week after I've pushed the current 5.1 patches. Can you respin
this one on top of for-5.2/block when it comes out?
--
Jens Axboe
next prev parent reply other threads:[~2019-03-28 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 3:50 [PATCH] block: clarify that bio_add_page() and related helpers can add multi pages Ming Lei
2019-03-28 14:21 ` Jens Axboe [this message]
2019-03-28 15:03 ` Christoph Hellwig
2019-03-28 15:07 ` Jens Axboe
2019-03-28 15:31 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2019-04-02 2:36 Ming Lei
2019-04-03 14:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5258cad3-b324-660f-589f-73eb7fb8fa04@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).