From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 094A47F4E for ; Sat, 12 Oct 2013 16:07:42 -0500 (CDT) Message-ID: <5259BA1A.1060202@sgi.com> Date: Sat, 12 Oct 2013 16:07:38 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 1/4 V2] xfs: remove newlines from strings passed to __xfs_printk References: <52584C8A.1060808@redhat.com> <52584D04.3020907@sandeen.net> <5258ACE9.6000401@sandeen.net> In-Reply-To: <5258ACE9.6000401@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Eric Sandeen , xfs-oss On 10/11/13 20:59, Eric Sandeen wrote: > __xfs_printk adds its own "\n". Having it in the original string > leads to unintentional blank lines from these messages. > > Most format strings have no newline, but a few do, leading to > i.e.: > > [ 7347.119911] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 > [ 7347.119911] > [ 7347.119919] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 > [ 7347.119919] > > Fix them all. > > Signed-off-by: Eric Sandeen > --- Thanks for the updated patch. It looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs