Re: [PATCH 1/4] xfs: remove newlines from 3 xfs_alert_tag error strings

Mark Tinguely
2013-10-11T21:59:09Z

On 10/11/13 14:09, Eric Sandeen wrote:
> xfs_alert_tag passes the format string to __xfs_printk,
> which adds its own "\n". Having it in the original string
> leads to unintentional blank lines from these messages.
>
> Most format strings have no newline, but these 3 do, leading to
> i.e.:
>
> [ 7347.119911] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05
> [ 7347.119911]
> [ 7347.119919] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05
> [ 7347.119919]
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> Reviewed-by: Carlos Maiolino<cmaiolino@redhat.com>
> ---

Is this true of xfs_alert() too? ie the newline in xfs_alert in
xfs_dir2_leafn_rebalance(). The newline in xfs_alert() in
xlog_unpack_data_crc() looks intentional.

--Mark.