* [PATCH] xfstests: fix xfs/205 for new log size defaults
@ 2013-10-09 19:48 Eric Sandeen
2013-10-09 20:28 ` Dave Chinner
2013-10-16 20:46 ` Rich Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2013-10-09 19:48 UTC (permalink / raw)
To: xfs-oss
test xfs/205 expects a certain log size, but defaults have
changed, the logs are bigger, and this test now fails w/ early
ENOSPC:
QA output created by 205
+ !!! disk full (expected)
+ !!! disk full (expected)
+ !!! disk full (expected)
*** one file
+ !!! disk full (expected)
*** one file, a few bytes at a time
...
Fix this by specifying the log size at mkfs time, so freespace is
as the test expects it to be.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/205 b/tests/xfs/205
index c9b73a1..0c071ca 100755
--- a/tests/xfs/205
+++ b/tests/xfs/205
@@ -41,7 +41,7 @@ _require_scratch
rm -f $seqres.full
-_scratch_mkfs_xfs -d size=16m -b size=512 >> $seqres.full 2>&1
+_scratch_mkfs_xfs -d size=16m -b size=512 -l size=4944b >> $seqres.full 2>&1
_scratch_mount
# fix the reserve block pool to a known size so that the enospc calculations
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: fix xfs/205 for new log size defaults
2013-10-09 19:48 [PATCH] xfstests: fix xfs/205 for new log size defaults Eric Sandeen
@ 2013-10-09 20:28 ` Dave Chinner
2013-10-16 20:46 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2013-10-09 20:28 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Wed, Oct 09, 2013 at 02:48:45PM -0500, Eric Sandeen wrote:
> test xfs/205 expects a certain log size, but defaults have
> changed, the logs are bigger, and this test now fails w/ early
> ENOSPC:
>
> QA output created by 205
> + !!! disk full (expected)
> + !!! disk full (expected)
> + !!! disk full (expected)
> *** one file
> + !!! disk full (expected)
> *** one file, a few bytes at a time
> ...
>
> Fix this by specifying the log size at mkfs time, so freespace is
> as the test expects it to be.
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: fix xfs/205 for new log size defaults
2013-10-09 19:48 [PATCH] xfstests: fix xfs/205 for new log size defaults Eric Sandeen
2013-10-09 20:28 ` Dave Chinner
@ 2013-10-16 20:46 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-10-16 20:46 UTC (permalink / raw)
To: Eric Sandeen, xfs-oss
This has been committed.
Thanks
--Rich
commit a49141302f71b9dbbd6033a5aaa93a984475dbb4
Author: Eric Sandeen <sandeen@redhat.com>
Date: Wed Oct 9 19:48:45 2013 +0000
xfstests: fix xfs/205 for new log size defaults
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-16 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-09 19:48 [PATCH] xfstests: fix xfs/205 for new log size defaults Eric Sandeen
2013-10-09 20:28 ` Dave Chinner
2013-10-16 20:46 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox