* [PATCH V3] mkfs: add noalign option to usage()
@ 2013-08-30 17:09 Carlos Maiolino
2013-08-31 1:23 ` Eric Sandeen
2013-10-18 16:31 ` Rich Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Carlos Maiolino @ 2013-08-30 17:09 UTC (permalink / raw)
To: xfs
Although it has been added to manpage, there is no information about the
existence of noalign option into the usage().
Changelog:
V2: Remove space in comma separated options
V3: Aligned the option together with another alignment options to make mutual
exclusive options more visible
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
mkfs/xfs_mkfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 4bdacee..b0c3ce5 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3032,7 +3032,7 @@ usage( void )
/* blocksize */ [-b log=n|size=num]\n\
/* metadata */ [-m crc=[0|1]\n\
/* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
- (sunit=value,swidth=value|su=num,sw=num),\n\
+ (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
sectlog=n|sectsize=num\n\
/* force overwrite */ [-f]\n\
/* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] mkfs: add noalign option to usage()
2013-08-30 17:09 [PATCH V3] mkfs: add noalign option to usage() Carlos Maiolino
@ 2013-08-31 1:23 ` Eric Sandeen
2013-10-18 16:31 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2013-08-31 1:23 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: xfs@oss.sgi.com
On Aug 30, 2013, at 12:09 PM, Carlos Maiolino <cmaiolino@redhat.com> wrote:
> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
>
> Changelog:
>
> V2: Remove space in comma separated options
> V3: Aligned the option together with another alignment options to make mutual
> exclusive options more visible
>
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..b0c3ce5 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3032,7 +3032,7 @@ usage( void )
> /* blocksize */ [-b log=n|size=num]\n\
> /* metadata */ [-m crc=[0|1]\n\
> /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> - (sunit=value,swidth=value|su=num,sw=num),\n\
> + (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
> sectlog=n|sectsize=num\n\
> /* force overwrite */ [-f]\n\
> /* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> --
> 1.8.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] mkfs: add noalign option to usage()
2013-08-30 17:09 [PATCH V3] mkfs: add noalign option to usage() Carlos Maiolino
2013-08-31 1:23 ` Eric Sandeen
@ 2013-10-18 16:31 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-10-18 16:31 UTC (permalink / raw)
To: Carlos Maiolino, xfs
This has been committed.
Thanks
--Rich
commit 91e684d140c000c074b9ca13821b6ec00146da36
Author: Carlos Maiolino <cmaiolino@redhat.com>
Date: Fri Aug 30 17:09:50 2013 +0000
mkfs: add noalign option to usage()
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-18 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 17:09 [PATCH V3] mkfs: add noalign option to usage() Carlos Maiolino
2013-08-31 1:23 ` Eric Sandeen
2013-10-18 16:31 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox