[PATCH V3] mkfs: add noalign option to usage()

[PATCH V3] mkfs: add noalign option to usage()

[Carlos Maiolino]

Although it has been added to manpage, there is no information about the
existence of noalign option into the usage().

Changelog:

V2: Remove space in comma separated options
V3: Aligned the option together with another alignment options to make mutual
    exclusive options more visible


Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 mkfs/xfs_mkfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 4bdacee..b0c3ce5 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3032,7 +3032,7 @@ usage( void )
 /* blocksize */		[-b log=n|size=num]\n\
 /* metadata */		[-m crc=[0|1]\n\
 /* data subvol */	[-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
-			    (sunit=value,swidth=value|su=num,sw=num),\n\
+			    (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
 			    sectlog=n|sectsize=num\n\
 /* force overwrite */	[-f]\n\
 /* inode size */	[-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH V3] mkfs: add noalign option to usage()

[Eric Sandeen]

On Aug 30, 2013, at 12:09 PM, Carlos Maiolino <cmaiolino@redhat.com> wrote:

> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
> 
> Changelog:
> 
> V2: Remove space in comma separated options
> V3: Aligned the option together with another alignment options to make mutual
>    exclusive options more visible
> 
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..b0c3ce5 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3032,7 +3032,7 @@ usage( void )
> /* blocksize */        [-b log=n|size=num]\n\
> /* metadata */        [-m crc=[0|1]\n\
> /* data subvol */    [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> -                (sunit=value,swidth=value|su=num,sw=num),\n\
> +                (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
>                sectlog=n|sectsize=num\n\
> /* force overwrite */    [-f]\n\
> /* inode size */    [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> -- 
> 1.8.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH V3] mkfs: add noalign option to usage()

[Rich Johnston]

This has been committed.

Thanks
--Rich

commit 91e684d140c000c074b9ca13821b6ec00146da36
Author: Carlos Maiolino <cmaiolino@redhat.com>
Date:   Fri Aug 30 17:09:50 2013 +0000

     mkfs: add noalign option to usage()

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs