From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <eguan@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: generic/317 318 need procfs uid_map/gid_map support
Date: Tue, 29 Oct 2013 12:55:26 -0500 [thread overview]
Message-ID: <526FF68E.9070500@sandeen.net> (raw)
In-Reply-To: <1383049068-3020-1-git-send-email-eguan@redhat.com>
On 10/29/13 7:17 AM, Eryu Guan wrote:
> generic/317 and 318 need /proc/<pid>/[uid_map|gid_map], test fail on
> older kernels without that support.
>
> Add a _require_ugid_map() function and called by 317 and 318.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> common/rc | 10 ++++++++++
> tests/generic/317 | 1 +
> tests/generic/318 | 1 +
> 3 files changed, 12 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index b5eb582..ea3af12 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2142,6 +2142,16 @@ _require_dumpe2fs()
> fi
> }
>
> +_require_ugid_map()
> +{
> + if [ ! -e /proc/self/uid_map ]; then
> + _notrun "This test requires procfs uid_map support."
> + fi
> + if [ ! -e /proc/self/gid_map ]; then
> + _notrun "This test requires procfs gid_map support."
> + fi
> +}
> +
> _create_loop_device()
> {
> file=$1
> diff --git a/tests/generic/317 b/tests/generic/317
> index 6d8d3c4..c042f79 100644
> --- a/tests/generic/317
> +++ b/tests/generic/317
> @@ -63,6 +63,7 @@ rm -f $seqres.full
> _require_scratch
> _need_to_be_root
> _require_user
> +_require_ugid_map
> qa_user_id=`grep $qa_user /etc/passwd |awk -F: '{print $3}'`
>
> _filter_output()
> diff --git a/tests/generic/318 b/tests/generic/318
> index d3bce51..3e8eb50 100755
> --- a/tests/generic/318
> +++ b/tests/generic/318
> @@ -63,6 +63,7 @@ _require_scratch
> _need_to_be_root
> _acl_setup_ids
> _require_acls
> +_require_ugid_map
>
> _print_getfacls()
> {
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-29 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 12:17 [PATCH] xfstests: generic/317 318 need procfs uid_map/gid_map support Eryu Guan
2013-10-29 17:55 ` Eric Sandeen [this message]
2013-11-04 20:36 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526FF68E.9070500@sandeen.net \
--to=sandeen@sandeen.net \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox