From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs: remove unused "verbose" argument from xfs_setsize_buftarg path
Date: Wed, 13 Nov 2013 11:52:11 -0600 [thread overview]
Message-ID: <5283BC4B.9090204@redhat.com> (raw)
The "verbose" argument has been unused since
ffe37436 xfs: stop using the page cache to back the buffer cache
Remove it, and then give the function a better (?) name since
no flags are involved.
Fix inconsistent comment spacing while we're at it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 2634700..85d916a 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1602,11 +1602,10 @@ xfs_free_buftarg(
}
STATIC int
-xfs_setsize_buftarg_flags(
+__xfs_setsize_buftarg(
xfs_buftarg_t *btp,
unsigned int blocksize,
- unsigned int sectorsize,
- int verbose)
+ unsigned int sectorsize)
{
btp->bt_bsize = blocksize;
btp->bt_sshift = ffs(sectorsize) - 1;
@@ -1627,17 +1626,17 @@ xfs_setsize_buftarg_flags(
}
/*
- * When allocating the initial buffer target we have not yet
- * read in the superblock, so don't know what sized sectors
- * are being used at this early stage. Play safe.
+ * When allocating the initial buffer target we have not yet
+ * read in the superblock, so don't know what sized sectors
+ * are being used at this early stage. Play safe.
*/
STATIC int
xfs_setsize_buftarg_early(
xfs_buftarg_t *btp,
struct block_device *bdev)
{
- return xfs_setsize_buftarg_flags(btp,
- PAGE_SIZE, bdev_logical_block_size(bdev), 0);
+ return __xfs_setsize_buftarg(btp,
+ PAGE_SIZE, bdev_logical_block_size(bdev));
}
int
@@ -1646,7 +1645,7 @@ xfs_setsize_buftarg(
unsigned int blocksize,
unsigned int sectorsize)
{
- return xfs_setsize_buftarg_flags(btp, blocksize, sectorsize, 1);
+ return __xfs_setsize_buftarg(btp, blocksize, sectorsize);
}
xfs_buftarg_t *
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-11-13 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 17:52 Eric Sandeen [this message]
2013-11-13 18:42 ` [PATCH] xfs: remove unused "verbose" argument from xfs_setsize_buftarg path Brian Foster
2013-11-13 18:50 ` Eric Sandeen
2013-11-13 20:53 ` [PATCH V2] xfs: simplify xfs_setsize_buftarg callchain; remove unused arg Eric Sandeen
2013-11-13 21:26 ` Brian Foster
2013-12-04 21:52 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283BC4B.9090204@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox