[PATCH] xfstest generic/280: wait for setquota to finish before umount

[PATCH] xfstest generic/280: wait for setquota to finish before umount

[Guangyu Sun]

While running xfstest 280, we occasionally got such error:

  setquota: Cannot set quota for user 0 from kernel on
  /dev/mapper/xfstests-disk1: No such device
  setquota: Cannot write quota for 0 on /dev/mapper/xfstests-disk1: No such
  device

setquota calls syscall quotactl, and the kernel will wait for the filesystem
to unfreeze and then performs command. Then kernel will double check if the
device is still mounted. If not, an ENODEV will be thrown.

While in the testcase, unfreeze and umount might be so close that the device
got umounted before quotactl is performed.

Reported-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Signed-off-by: Guangyu Sun <guangyu.sun@oracle.com>
---
 tests/generic/280 |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/generic/280 b/tests/generic/280
index 5491a6b..815a2c5 100755
--- a/tests/generic/280
+++ b/tests/generic/280
@@ -63,6 +63,7 @@ xfs_freeze -f $SCRATCH_MNT
 setquota -u root 1 2 3 4 $SCRATCH_MNT &
 sleep 1
 xfs_freeze -u $SCRATCH_MNT
+sleep 1
 umount $SCRATCH_DEV
 
 # Failure comes in the form of a deadlock.
-- 
1.7.9.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstest generic/280: wait for setquota to finish before umount

[Stanislav Kholmanskikh]

On 10/24/2013 09:56 PM, Guangyu Sun wrote:
> While running xfstest 280, we occasionally got such error:
>
>    setquota: Cannot set quota for user 0 from kernel on
>    /dev/mapper/xfstests-disk1: No such device
>    setquota: Cannot write quota for 0 on /dev/mapper/xfstests-disk1: No such
>    device
>
> setquota calls syscall quotactl, and the kernel will wait for the filesystem
> to unfreeze and then performs command. Then kernel will double check if the
> device is still mounted. If not, an ENODEV will be thrown.
>
> While in the testcase, unfreeze and umount might be so close that the device
> got umounted before quotactl is performed.
>
> Reported-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> Signed-off-by: Guangyu Sun <guangyu.sun@oracle.com>
> ---
>   tests/generic/280 |    1 +
>   1 file changed, 1 insertion(+)
Hi!

Could anybody review this?

Thanks.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstest generic/280: wait for setquota to finish before umount

[Eric Sandeen]

On 10/24/13, 12:56 PM, Guangyu Sun wrote:
> While running xfstest 280, we occasionally got such error:
> 
>   setquota: Cannot set quota for user 0 from kernel on
>   /dev/mapper/xfstests-disk1: No such device
>   setquota: Cannot write quota for 0 on /dev/mapper/xfstests-disk1: No such
>   device
> 
> setquota calls syscall quotactl, and the kernel will wait for the filesystem
> to unfreeze and then performs command. Then kernel will double check if the
> device is still mounted. If not, an ENODEV will be thrown.
> 
> While in the testcase, unfreeze and umount might be so close that the device
> got umounted before quotactl is performed.
> 
> Reported-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> Signed-off-by: Guangyu Sun <guangyu.sun@oracle.com>

Wanted to make sure the sleep didn't disturb the deadlock it's testing,
and it doesn't.  So:

Reviewed-by: Eric Sandeen <sandeen@redaht.com>

Thanks,
-Eric

> ---
>  tests/generic/280 |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/280 b/tests/generic/280
> index 5491a6b..815a2c5 100755
> --- a/tests/generic/280
> +++ b/tests/generic/280
> @@ -63,6 +63,7 @@ xfs_freeze -f $SCRATCH_MNT
>  setquota -u root 1 2 3 4 $SCRATCH_MNT &
>  sleep 1
>  xfs_freeze -u $SCRATCH_MNT
> +sleep 1
>  umount $SCRATCH_DEV
>  
>  # Failure comes in the form of a deadlock.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstest generic/280: wait for setquota to finish before umount

[Rich Johnston]

This has been committed.

Thanks
--Rich

commit 527eeb43e5c7cfd642d81bc3c12e746d2a3733ff
Author: Guangyu Sun <guangyu.sun@oracle.com>
Date:   Thu Oct 24 17:56:21 2013 +0000

     xfstest generic/280: wait for setquota to finish before umount

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstest generic/280: wait for setquota to finish before umount

[Dave Chinner]

On Tue, Dec 03, 2013 at 09:00:48AM -0600, Rich Johnston wrote:
> This has been committed.
> 
> Thanks
> --Rich
> 
> commit 527eeb43e5c7cfd642d81bc3c12e746d2a3733ff
> Author: Guangyu Sun <guangyu.sun@oracle.com>
> Date:   Thu Oct 24 17:56:21 2013 +0000
> 
>     xfstest generic/280: wait for setquota to finish before umount

Rich, I know you read the email I sent about trying to
introduce some conventions for patch subject lines for xfstests
commits.  Cleanliness in the commit history is important, and it's
something that we need to focus on to ensure we all commit patches
using the same conventions.

Hence if you are going to commit patches independently, can you can
you please rewrite the commit messages to follow the conventions I
outlined?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs