* [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c
@ 2013-11-14 20:54 Eric Sandeen
2013-11-14 21:04 ` Dave Chinner
2013-11-18 19:03 ` Rich Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2013-11-14 20:54 UTC (permalink / raw)
To: xfs-oss
The commit:
800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db
introduced a stray semicolon during the refactoring. Luckily it
only breaks the error case.
(Caught by Coverity, CID 1128894)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 0aa2eba..0219a08 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf *bp,
offset += len;
}
- if (!error);
+ if (!error)
bp->b_flags |= LIBXFS_B_UPTODATE;
#ifdef IO_DEBUG
printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c
2013-11-14 20:54 [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c Eric Sandeen
@ 2013-11-14 21:04 ` Dave Chinner
2013-11-18 19:03 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2013-11-14 21:04 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Nov 14, 2013 at 02:54:02PM -0600, Eric Sandeen wrote:
> The commit:
>
> 800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db
>
> introduced a stray semicolon during the refactoring. Luckily it
> only breaks the error case.
>
> (Caught by Coverity, CID 1128894)
My fault, but really, this is something that gcc should warn about
because it's almost always a bug....
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 0aa2eba..0219a08 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf *bp,
> offset += len;
> }
>
> - if (!error);
> + if (!error)
> bp->b_flags |= LIBXFS_B_UPTODATE;
> #ifdef IO_DEBUG
> printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c
2013-11-14 20:54 [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c Eric Sandeen
2013-11-14 21:04 ` Dave Chinner
@ 2013-11-18 19:03 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-11-18 19:03 UTC (permalink / raw)
To: Eric Sandeen, xfs-oss
This has been committed.
Thanks
--Rich
Author: Eric Sandeen <sandeen@redhat.com>
Date: Thu Nov 14 20:54:02 2013 +0000
xfsprogs: Fix stray semicolon in libxfs/rdwr.c
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-18 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-14 20:54 [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c Eric Sandeen
2013-11-14 21:04 ` Dave Chinner
2013-11-18 19:03 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox