Re: [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f

[Jeff Liu <jeff.liu@oracle.com>]

On 11/15 2013 23:36 PM, Jeff Liu wrote:
> On 11/15 2013 22:09, Christoph Hellwig wrote:
>> On Fri, Nov 15, 2013 at 09:42:03AM +0800, Jeff Liu wrote:
>>> As per a rough tryout while fixing this problem, it seems that most of those
>>> functions are just not be invoked since other precheck-ups were failed before
>>> calling them.  We have another old fix for stat_f():
>>
>> Most or all?  If this is the only case I'm fine with putting your
>> patch in a quick fix, even if I'd prefer the version I suggested for
>> the long run.
> Most.  I'm in the middle of this check because I found another critical
> bug in kernel quota management which can cause xfs_quota hang up, it can
> 100% reproducible but still under investigation.
Sorry for the delay!  I can not find more problems.

AFAICS, there are 6 administrator commands dereference fs_path for further
operation, i.e, free, path, limit, quot, state, report.
Except report, state has already been fixed with fs_path precheck-up, the
others are safe as additional precheck-ups failed.

Thanks,
-Jeff


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs