From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH V2] xfsprogs: suggest "-d" option for repair of RO mount
Date: Mon, 18 Nov 2013 10:02:05 -0600 [thread overview]
Message-ID: <528A39FD.5090109@sandeen.net> (raw)
In-Reply-To: <528261AD.50501@redhat.com>
We can offer the suggestion of a "-d" repair, if we're
in single-user mode with i.e. the root fs mounted readonly.
This change suggests -d to repair any RO mounted fs.
e2fsck allows this, and users are used to being able to
do it in single-user mode. A separate patch will recommend
a reboot after repair completes.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: Now with more danger!
diff --git a/repair/init.c b/repair/init.c
index c3f380b..a7a7613 100644
--- a/repair/init.c
+++ b/repair/init.c
@@ -97,8 +97,17 @@ xfs_init(libxfs_init_t *args)
else
args->isreadonly = LIBXFS_EXCLUSIVELY;
- if (!libxfs_init(args))
+ if (!libxfs_init(args)) {
+ /* would -d be an option? */
+ if (!no_modify && !dangerously) {
+ args->isreadonly = (LIBXFS_ISINACTIVE |
+ LIBXFS_DANGEROUSLY);
+ if (libxfs_init(args))
+ fprintf(stderr,
+_("Unmount or use the dangerous (-d) option to repair a read-only mounted filesystem\n"));
+ }
do_error(_("couldn't initialize XFS library\n"));
+ }
ts_create();
increase_rlimit();
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-18 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 17:13 [PATCH RFC] xfsprogs: suggest "-d" option for repair of RO mount Eric Sandeen
2013-11-13 12:59 ` Carlos Maiolino
2013-11-14 18:55 ` Eric Sandeen
2013-11-17 19:56 ` Dave Chinner
2013-11-18 15:56 ` Eric Sandeen
2013-11-18 16:02 ` Eric Sandeen [this message]
2013-11-18 22:26 ` [PATCH V2] " Dave Chinner
2013-12-03 14:42 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A39FD.5090109@sandeen.net \
--to=sandeen@sandeen.net \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox