[PATCH] xfs_repair: correct docs for "-t" units

[PATCH] xfs_repair: correct docs for "-t" units

[Eric Sandeen]

usage() says that the xfs_repair -t reporting interval is
in minutes, and the manpage says nothing at all about units.

Actually, it's in seconds.

Clarify in both places that the interval is specified in
seconds.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/man/man8/xfs_repair.8 b/man/man8/xfs_repair.8
index 47436ec..ed20fb7 100644
--- a/man/man8/xfs_repair.8
+++ b/man/man8/xfs_repair.8
@@ -152,7 +152,7 @@ in no modify mode first.
 .RE
 .TP
 .B \-t " interval"
-Modify reporting interval. During long runs
+Modify reporting interval, specified in seconds. During long runs
 .B xfs_repair
 outputs its progress every 15 minutes. Reporting is only activated when
 ag_stride is enabled.
diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
index a863337..7beffcb 100644
--- a/repair/xfs_repair.c
+++ b/repair/xfs_repair.c
@@ -90,7 +90,7 @@ usage(void)
 "  -v           Verbose output.\n"
 "  -c subopts   Change filesystem parameters - use xfs_admin.\n"
 "  -o subopts   Override default behaviour, refer to man page.\n"
-"  -t interval  Reporting interval in minutes.\n"
+"  -t interval  Reporting interval in seconds.\n"
 "  -d           Repair dangerously.\n"
 "  -V           Reports version and exits.\n"), progname);
 	exit(1);

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_repair: correct docs for "-t" units

[Dave Chinner]

On Thu, Nov 14, 2013 at 02:38:08PM -0600, Eric Sandeen wrote:
> usage() says that the xfs_repair -t reporting interval is
> in minutes, and the manpage says nothing at all about units.
> 
> Actually, it's in seconds.
> 
> Clarify in both places that the interval is specified in
> seconds.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_repair: correct docs for "-t" units

[Rich Johnston]

This has been committed.

Thanks
--Rich

commit 79e106f05f0fbffb89ab5401fb97af5391c6291f
Author: Eric Sandeen <sandeen@redhat.com>
Date:   Thu Nov 14 20:38:08 2013 +0000

     xfs_repair: correct docs for "-t" units

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs