* [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
@ 2013-11-22 15:11 Jeff Liu
2013-11-22 15:17 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Liu @ 2013-11-22 15:11 UTC (permalink / raw)
To: xfs@oss.sgi.com
From: Jie Liu <jeff.liu@oracle.com>
For CRC enabled v5 super block, change a file's ownership can simply
trigger ASSERT failure at xfs_setattr_nonsize() if both group and
project quota are enabled, e.g,
[ 305.337609] XFS: Assertion failed: !XFS_IS_PQUOTA_ON(mp), file: fs/xfs/xfs_iops.c, line: 621
[ 305.339250] Kernel BUG at ffffffffa0a7fa32 [verbose debug info unavailable]
[ 305.383939] Call Trace:
[ 305.385536] [<ffffffffa0a7d95a>] xfs_setattr_nonsize+0x69a/0x720 [xfs]
[ 305.387142] [<ffffffffa0a7dea9>] xfs_vn_setattr+0x29/0x70 [xfs]
[ 305.388727] [<ffffffff811ca388>] notify_change+0x1a8/0x350
[ 305.390298] [<ffffffff811ac39d>] chown_common+0xfd/0x110
[ 305.391868] [<ffffffff811ad6bf>] SyS_fchownat+0xaf/0x110
[ 305.393440] [<ffffffff811ad760>] SyS_lchown+0x20/0x30
[ 305.394995] [<ffffffff8170f7dd>] system_call_fastpath+0x1a/0x1f
[ 305.399870] RIP [<ffffffffa0a7fa32>] assfail+0x22/0x30 [xfs]
To remain the current semantics under the debug mode, this fix add
an additional judgement to make this assertion only works for non-CRC
enabled version.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/xfs/xfs_iops.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 27e0e54..586f1f2 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -618,7 +618,10 @@ xfs_setattr_nonsize(
}
if (!gid_eq(igid, gid)) {
if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
- ASSERT(!XFS_IS_PQUOTA_ON(mp));
+#ifdef DEBUG
+ if (!xfs_sb_version_has_pquotino(&mp->m_sb))
+ ASSERT(!XFS_IS_PQUOTA_ON(mp));
+#endif
ASSERT(mask & ATTR_GID);
ASSERT(gdqp);
olddquot2 = xfs_qm_vop_chown(tp, ip,
--
1.7.9.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
2013-11-22 15:11 [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize Jeff Liu
@ 2013-11-22 15:17 ` Christoph Hellwig
2013-11-22 15:34 ` Jeff Liu
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2013-11-22 15:17 UTC (permalink / raw)
To: Jeff Liu; +Cc: xfs@oss.sgi.com
On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
> To remain the current semantics under the debug mode, this fix add
> an additional judgement to make this assertion only works for non-CRC
> enabled version.
> if (!gid_eq(igid, gid)) {
> if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
> - ASSERT(!XFS_IS_PQUOTA_ON(mp));
> +#ifdef DEBUG
> + if (!xfs_sb_version_has_pquotino(&mp->m_sb))
> + ASSERT(!XFS_IS_PQUOTA_ON(mp));
> +#endif
> ASSERT(mask & ATTR_GID);
> ASSERT(gdqp);
I'd just kill this assert. And it would be good to get some coverage
of running with all three quotas types into xfstests by default..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
2013-11-22 15:17 ` Christoph Hellwig
@ 2013-11-22 15:34 ` Jeff Liu
2013-11-22 15:38 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Liu @ 2013-11-22 15:34 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs@oss.sgi.com
On 11/22 2013 23:17 PM, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
>> To remain the current semantics under the debug mode, this fix add
>> an additional judgement to make this assertion only works for non-CRC
>> enabled version.
>
>> if (!gid_eq(igid, gid)) {
>> if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
>> - ASSERT(!XFS_IS_PQUOTA_ON(mp));
>> +#ifdef DEBUG quota
>> + if (!xfs_sb_version_has_pquotino(&mp->m_sb))
>> + ASSERT(!XFS_IS_PQUOTA_ON(mp));
>> +#endif
>> ASSERT(mask & ATTR_GID);
>> ASSERT(gdqp);
>
> I'd just kill this assert.
I hesitated about killing this assertion or hold the line before, will fix it soon.
> And it would be good to get some coverage
> of running with all three quotas types into xfstests by default..
Definitely! I just found another race problem between dquot attach and quota off via
fsstress as per Dave's suggestion for another fix. :)
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
2013-11-22 15:34 ` Jeff Liu
@ 2013-11-22 15:38 ` Christoph Hellwig
2013-11-22 15:56 ` Jeff Liu
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2013-11-22 15:38 UTC (permalink / raw)
To: Jeff Liu; +Cc: Christoph Hellwig, xfs@oss.sgi.com
On Fri, Nov 22, 2013 at 11:34:07PM +0800, Jeff Liu wrote:
> On 11/22 2013 23:17 PM, Christoph Hellwig wrote:
> > On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
> >> To remain the current semantics under the debug mode, this fix add
> >> an additional judgement to make this assertion only works for non-CRC
> >> enabled version.
> >
> >> if (!gid_eq(igid, gid)) {
> >> if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
> >> - ASSERT(!XFS_IS_PQUOTA_ON(mp));
> >> +#ifdef DEBUG quota
> >> + if (!xfs_sb_version_has_pquotino(&mp->m_sb))
> >> + ASSERT(!XFS_IS_PQUOTA_ON(mp));
> >> +#endif
> >> ASSERT(mask & ATTR_GID);
> >> ASSERT(gdqp);
> >
> > I'd just kill this assert.
> I hesitated about killing this assertion or hold the line before, will fix it soon.
If we want to keep it maybe write is a little nicer:
ASSERT(xfs_sb_version_has_pquotino(&mp->m_sb) ||
!XFS_IS_PQUOTA_ON(mp));
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
2013-11-22 15:38 ` Christoph Hellwig
@ 2013-11-22 15:56 ` Jeff Liu
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Liu @ 2013-11-22 15:56 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs@oss.sgi.com
On 11/22/2013 11:38 PM, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 11:34:07PM +0800, Jeff Liu wrote:
>> On 11/22 2013 23:17 PM, Christoph Hellwig wrote:
>>> On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
>>>> To remain the current semantics under the debug mode, this fix add
>>>> an additional judgement to make this assertion only works for non-CRC
>>>> enabled version.
>>>
>>>> if (!gid_eq(igid, gid)) {
>>>> if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
>>>> - ASSERT(!XFS_IS_PQUOTA_ON(mp));
>>>> +#ifdef DEBUG quota
>>>> + if (!xfs_sb_version_has_pquotino(&mp->m_sb))
>>>> + ASSERT(!XFS_IS_PQUOTA_ON(mp));
>>>> +#endif
>>>> ASSERT(mask & ATTR_GID);
>>>> ASSERT(gdqp);
>>>
>>> I'd just kill this assert.
>> I hesitated about killing this assertion or hold the line before, will fix it soon.
>
> If we want to keep it maybe write is a little nicer:
>
> ASSERT(xfs_sb_version_has_pquotino(&mp->m_sb) ||
> !XFS_IS_PQUOTA_ON(mp));
Nice point! I'd take this suggestion.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-22 15:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-22 15:11 [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize Jeff Liu
2013-11-22 15:17 ` Christoph Hellwig
2013-11-22 15:34 ` Jeff Liu
2013-11-22 15:38 ` Christoph Hellwig
2013-11-22 15:56 ` Jeff Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox