From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/3] xfstests: introduce xfs/324 to verify turn group/project quota off along with fsstress
Date: Tue, 03 Dec 2013 15:36:35 +0800 [thread overview]
Message-ID: <529D8A03.1060603@oracle.com> (raw)
In-Reply-To: <20131203005308.GK10988@dastard>
On 12/03 2013 08:53 AM, Dave Chinner wrote:
> On Fri, Nov 29, 2013 at 03:03:39PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Introduce xfs/324 to verify that we can turn group/project quotas off
>> while user quota is on and fsstress is running.
>>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ....
>> +
>> +# Modify as appropriate.
>> +_supported_fs xfs
>> +_supported_os Linux
>> +
>> +_require_scratch
>> +_require_xfs_quota
>> +_require_xfs_crc_sb
>
> Hmmm, now that I look at the way you are using _require_xfs_crc_sb,
> it's broken. The scratch device is in an undefined state until a
> test runs _scratch_mkfs on it.
>
> What you need to do is check whether mkfs supports "-m crc=1", and
> then mkfs the scratch device with that option set.
Got it.
>
>> +
>> +_qmount_option "uquota,gquota,pquota"
>> +
>> +STRESS_DIR=$SCRATCH_MNT/testdir
>> +
>
> Where do you mkfs the scratch device?
Oops, this problem must be concealed as it has ran against the environment
from previous test.
>
>> +_exercise()
>> +{
>> + type=$1
>> +
>> + _qmount
>> + mkdir -p $STRESS_DIR
>> +
>> + $FSSTRESS_PROG -d $STRESS_DIR -n 100 -p 1000 $FSSTRESS_AVOID >>/dev/null 2>&1 &
>
> There's no real reason for creating a load of 1000 processes here.
> Half of them won't even get started before this:
>
>> + xfs_quota -x -c "off -$type" $SCRATCH_DEV
>
> is run.
>
>> + killall -q $FSSTRESS_PROG
>> + wait
>
> and then you kill them straight away.
>
>> + rm -rf $STRESS_DIR
>> + umount $SCRATCH_MNT
>
> You don't need this if you just scratch_mkfs the device between
> tests.
>
> So, wouldn't it be better to do:
>
> scratch_mkfs -m crc=1
> _qmount
> mkdir -p $STRESS_DIR
> $FSSTRESS_PROG -d $STRESS_DIR -n 1000 -p 100 $FSSTRESS_AVOID >>/dev/null 2>&1 &
> sleep 10
> xfs_quota -x -c "off -$type" $SCRATCH_DEV
> sleep 5
> killall -q $FSSTRESS_PROG
> wait
Above problems will be fixed in next round of post.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-03 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 7:03 [PATCH 3/3] xfstests: introduce xfs/324 to verify turn group/project quota off along with fsstress Jeff Liu
2013-12-03 0:53 ` Dave Chinner
2013-12-03 7:36 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D8A03.1060603@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox