Re: [PATCH RFC] xfsprogs: suggest "-d" option for repair of RO mount

Dave Chinner
2013-11-17T19:56:30Z

On Thu, Nov 14, 2013 at 12:55:37PM -0600, Eric Sandeen wrote:
> On 11/13/13, 6:59 AM, Carlos Maiolino wrote:
> > Hm, even in single user with a RO root filesystem, changing filesystem
> > on-disk filesystem structures without have them replied in memory looks
> > dangerous to me, you will keep data consistency since the fs is RO, but how
> > about memory? You might have a discrepancy between memory and disk metadata
> > contents causing in-memory only problems?
> >
>
> The possibility is already there; it's just a question of whether we
> suggest using it. And my other patch suggests an immediate reboot
> when it's done, for just those reasons.

If you make the suggestion of using -d, then it should mention at
that point in time it's dangerous.

> A user needs some way to repair their root disk if they can't boot
> a rescue environment... and ext2/3/4 have been doing this since forever.
>
> I know, none of the above are exactly arguments that its' safe... :)

Right, so let's make sure we don't give people any impression it is
safe :)

> >> +_("Unmount or use -d to repair a read-only mounted filesystem\n"));

_("Unmount or use the dangerous (-d) option to repair a read-only mounted filesystem\n"));

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com