public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
Date: Fri, 06 Dec 2013 10:59:41 +0400	[thread overview]
Message-ID: <52A175DD.5050908@oracle.com> (raw)
In-Reply-To: <20131107204635.GA22954@infradead.org>


On 11/08/2013 12:46 AM, Christoph Hellwig wrote:
> For historical reasons beyond my knowledge xfstests tries to abuse the
> scratch device as test device for nfs and udf.  Because not all test
> have inherited the right usage of the _setup_testdir and _cleanup_testdir
> helpers this leads to lots of unessecary test failures.
>
> Remove the special casing, which gets nfs down to a minimal number of
> failures.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> diff --git a/common/rc b/common/rc
> index ea3af12..c64933a 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -975,11 +975,7 @@ _require_scratch()
>   {
>       case "$FSTYP" in
>   	nfs*)
> -		 echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1
> -		 if [ -z "$SCRATCH_DEV" -o "$?" != "0" ]
> -		 then
> -		     _notrun "this test requires a valid \$SCRATCH_DEV"
> -		 fi
> +                 _notrun "requires a scratch device"
>   		 ;;
>   	*)
>   		 if [ -z "$SCRATCH_DEV" -o "`_is_block_dev $SCRATCH_DEV`" = "" ]
> @@ -1773,100 +1769,6 @@ _full_platform_details()
>        echo "$os/$platform $host $kernel"
>   }
Hi!

Sorry for my post-commit "review".

But for what purposes did you delete this scratch device handling for nfs?
Now each test case that uses _require_scratch returns [not run].

It means most of the generic/ test cases.

I think we should revert this part of code. How do you think?

Thanks.


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-12-06  6:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 20:46 [PATCH] xfstests: stop special casing nfs and udf Christoph Hellwig
2013-11-12 17:35 ` Christoph Hellwig
2013-11-12 18:18 ` Eric Sandeen
2013-11-12 18:23   ` Eric Sandeen
2013-11-12 20:13     ` Jan Kara
2013-11-14 13:43       ` Christoph Hellwig
2013-11-12 18:32   ` Christoph Hellwig
2013-11-14 18:53 ` Eric Sandeen
2013-11-22  9:15 ` Christoph Hellwig
2013-12-02 17:40   ` Christoph Hellwig
2013-12-02 23:25     ` Dave Chinner
2013-12-02 23:36       ` Ben Myers
2013-12-03  4:29         ` Dave Chinner
2013-12-03 13:35           ` Rich Johnston
2013-12-03 23:30             ` Dave Chinner
2013-12-06  6:59 ` Stanislav Kholmanskikh [this message]
2013-12-06 16:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A175DD.5050908@oracle.com \
    --to=stanislav.kholmanskikh@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox