From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs: free the efi AIL entry on log recovery failure
Date: Wed, 11 Dec 2013 11:25:36 -0600 [thread overview]
Message-ID: <52A8A010.8070909@sgi.com> (raw)
In-Reply-To: <20131211113126.GA6248@infradead.org>
On 12/11/13 05:31, Christoph Hellwig wrote:
> Btw, I really think we need to get rid of abusing the AIL for
> tracking EFIs during log recovery before looking at the various
> leaks in this area. I've actually got a lightly tested patch for
> that, but didn't make much progress on that series. If you have
> and interest in that area and some spare QA cycles I'd recommend
> to base this on the patch below:
>
> ---
>> From b90935eaba9eb13c67101e5d723513bc6ca6e722 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig<hch@lst.de>
> Date: Sat, 23 Nov 2013 20:11:09 +0100
> Subject: [PATCH] xfs: simplify EFI/EFD recovery
>
> Use a cancellation table, similar to how we handle buffers instead of
> abusing the AIL during recovery.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
> fs/xfs/xfs_extfree_item.c | 8 +-
> fs/xfs/xfs_extfree_item.h | 6 --
> fs/xfs/xfs_log_priv.h | 1 +
> fs/xfs/xfs_log_recover.c | 183 +++++++++++++--------------------------------
> 4 files changed, 56 insertions(+), 142 deletions(-)
Good idea to remove EFI item recovery from the AIL. It may take some
time before I get to it.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-11 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 21:20 [PATCH 0/2] misc log recovery patches Mark Tinguely
2013-12-06 21:20 ` [PATCH 1/2] xfs: fix double free on error when cleaning log items Mark Tinguely
2013-12-09 0:29 ` Dave Chinner
2013-12-06 21:20 ` [PATCH 2/2] xfs: free the efi AIL entry on log recovery failure Mark Tinguely
2013-12-08 0:52 ` [PATCH v3] " Mark Tinguely
2013-12-09 1:00 ` Dave Chinner
2013-12-11 11:31 ` Christoph Hellwig
2013-12-11 17:25 ` Mark Tinguely [this message]
2013-12-23 16:42 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A8A010.8070909@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox