From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_bulkstat
Date: Thu, 12 Dec 2013 11:00:40 +0800 [thread overview]
Message-ID: <52A926D8.50107@oracle.com> (raw)
In-Reply-To: <20131211232741.GO10988@dastard>
On 12/12 2013 07:27 AM, Dave Chinner wrote:
> On Wed, Dec 11, 2013 at 09:48:14PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Use xfs_ialloc_blks_per_cluster() in xfs_bulkstat(), make the
>> related variables more meaningful and remove an unused variable
>> nimask from it.
>>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>> ---
>> fs/xfs/xfs_itable.c | 20 ++++++++------------
>> 1 file changed, 8 insertions(+), 12 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
>> index c237ad1..6671f5b 100644
>> --- a/fs/xfs/xfs_itable.c
>> +++ b/fs/xfs/xfs_itable.c
>> @@ -209,9 +209,8 @@ xfs_bulkstat(
>> xfs_inobt_rec_incore_t *irbuf; /* start of irec buffer */
>> xfs_inobt_rec_incore_t *irbufend; /* end of good irec buffer entries */
>> xfs_ino_t lastino; /* last inode number returned */
>> - int nbcluster; /* # of blocks in a cluster */
>> - int nicluster; /* # of inodes in a cluster */
>> - int nimask; /* mask for inode clusters */
>> + int blks_per_cluster; /* # of blocks in a cluster */
>> + int ninodes; /* # of inodes in a cluster */
>
> inodes_per_cluster?
Ok.
>
>> int nirbuf; /* size of irbuf */
>> int rval; /* return value error code */
>> int tmp; /* result value from btree calls */
>> @@ -243,11 +242,8 @@ xfs_bulkstat(
>> *done = 0;
>> fmterror = 0;
>> ubufp = ubuffer;
>> - nicluster = mp->m_sb.sb_blocksize >= XFS_INODE_CLUSTER_SIZE(mp) ?
>> - mp->m_sb.sb_inopblock :
>> - (XFS_INODE_CLUSTER_SIZE(mp) >> mp->m_sb.sb_inodelog);
>> - nimask = ~(nicluster - 1);
>> - nbcluster = nicluster >> mp->m_sb.sb_inopblog;
>> + blks_per_cluster = xfs_ialloc_blks_per_cluster(mp);
>
> Ok, now I see the helper name, perhaps it shoul dbe more like all
> the other conversion functions. "ialloc" means nothing in the
> context, and "blks" doesn't tell us the unit we are converting to
> - if could be basic blocks, it could be filesystem blocks. So,
> perhaps something like xfs_icluster_size_fsb()?
Sounds make sense to me, I'd like to adopt this name.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-12 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 13:48 [PATCH 2/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_bulkstat Jeff Liu
2013-12-11 23:27 ` Dave Chinner
2013-12-12 3:00 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A926D8.50107@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox