From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 4/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_ifree_cluster
Date: Thu, 12 Dec 2013 11:06:13 +0800 [thread overview]
Message-ID: <52A92825.6020406@oracle.com> (raw)
In-Reply-To: <20131211233101.GQ10988@dastard>
On 12/12 2013 07:31 AM, Dave Chinner wrote:
> On Wed, Dec 11, 2013 at 09:48:27PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Use xfs_ialloc_blks_per_cluster() in xfs_ifree_cluster()
>>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>> ---
>> fs/xfs/xfs_inode.c | 13 +++----------
>> 1 file changed, 3 insertions(+), 10 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
>> index 001aa89..7e75b8e 100644
>> --- a/fs/xfs/xfs_inode.c
>> +++ b/fs/xfs/xfs_inode.c
>> @@ -2152,16 +2152,9 @@ xfs_ifree_cluster(
>> struct xfs_perag *pag;
>>
>> pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, inum));
>> - if (mp->m_sb.sb_blocksize >= XFS_INODE_CLUSTER_SIZE(mp)) {
>> - blks_per_cluster = 1;
>> - ninodes = mp->m_sb.sb_inopblock;
>> - nbufs = XFS_IALLOC_BLOCKS(mp);
>> - } else {
>> - blks_per_cluster = XFS_INODE_CLUSTER_SIZE(mp) /
>> - mp->m_sb.sb_blocksize;
>> - ninodes = blks_per_cluster * mp->m_sb.sb_inopblock;
>> - nbufs = XFS_IALLOC_BLOCKS(mp) / blks_per_cluster;
>> - }
>> + blks_per_cluster = xfs_ialloc_blks_per_cluster(mp);
>> + ninodes = blks_per_cluster << mp->m_sb.sb_inopblog;
>> + nbufs = XFS_IALLOC_BLOCKS(mp) / blks_per_cluster;
>
> I'd get rid of the XFS_IALLOC_BLOCKS() macros there and just use
> mp->m_ialloc_blks directly. Otherwise looks good.
Agree, for the same reason as XFS_INODE_CLUSTER_SIZE() macros, I will
kill it. Oh, it looks we can get rid of XFS_IALLOC_INODES() marcos as
well...
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-12 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 13:48 [PATCH 4/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_ifree_cluster Jeff Liu
2013-12-11 23:31 ` Dave Chinner
2013-12-12 3:06 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A92825.6020406@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox