* [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster
@ 2013-12-12 7:37 Jeff Liu
2013-12-12 22:19 ` Dave Chinner
2013-12-13 11:15 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Liu @ 2013-12-12 7:37 UTC (permalink / raw)
To: xfs@oss.sgi.com
Hi Folks,
Here is the v2 patch series to introduce a common helper which could be used
to calculate the number of file system blocks in an inode cluster.
v2->v1:
* Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per dave's
suggestion.
* Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS
separately as preparation steps.
* s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
* Remove wrong commit notes I previously written for using xfs_ialloc_blks_per_cluster
in xfs_imap().
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster
2013-12-12 7:37 [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster Jeff Liu
@ 2013-12-12 22:19 ` Dave Chinner
2013-12-13 11:15 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2013-12-12 22:19 UTC (permalink / raw)
To: Jeff Liu; +Cc: xfs@oss.sgi.com
On Thu, Dec 12, 2013 at 03:37:42PM +0800, Jeff Liu wrote:
> Hi Folks,
>
> Here is the v2 patch series to introduce a common helper which could be used
> to calculate the number of file system blocks in an inode cluster.
>
> v2->v1:
> * Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per dave's
> suggestion.
> * Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS
> separately as preparation steps.
> * s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
> * Remove wrong commit notes I previously written for using xfs_ialloc_blks_per_cluster
> in xfs_imap().
All looks good, Jeff. Nice work, and thanks for adding all the extra
cleanups to it :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster
2013-12-12 7:37 [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster Jeff Liu
2013-12-12 22:19 ` Dave Chinner
@ 2013-12-13 11:15 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2013-12-13 11:15 UTC (permalink / raw)
To: Jeff Liu; +Cc: xfs@oss.sgi.com
The whole series looks good to me, although I've just posted two very
minor nitpicks.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-13 11:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-12 7:37 [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster Jeff Liu
2013-12-12 22:19 ` Dave Chinner
2013-12-13 11:15 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox