From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>, Ben Myers <bpm@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: return ENOSPC when trying to set more ACLs than XFS_ACL_MAX_ENTRIES
Date: Fri, 13 Dec 2013 21:32:09 +0800 [thread overview]
Message-ID: <52AB0C59.4070904@oracle.com> (raw)
In-Reply-To: <20131213130432.GB22594@infradead.org>
On 12/13 2013 21:04 PM, Christoph Hellwig wrote:
> On Wed, Dec 11, 2013 at 01:36:22PM -0600, Ben Myers wrote:
>>>> (I guess looking at ext4, it uses ENOSPC for some similar constraints,
>>>> so maybe three is precedent for this)
>>> Btrfs also uses ENOSPC, but JFS would return something like "Argument list too long"
>>> in this case.
>
> I think ENOSPC is a really bad idea in this case, but I also think we
> should make sure Linux filesystems behave unfiformly.
>
> Jeff, can you write a summary of the errors returned by all common
> filesystems and post it to -fsdevel for comment? We should have a
> common error for this, and I'd be a happier man if it weren't ENOSPC,
> but that's secondary.
Yep, let me gather up those info...
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-13 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 15:36 [PATCH] xfs: return ENOSPC when trying to set more ACLs than XFS_ACL_MAX_ENTRIES Jeff Liu
2013-11-25 3:34 ` Eric Sandeen
2013-11-25 4:57 ` Jeff Liu
2013-12-11 19:36 ` Ben Myers
2013-12-12 3:26 ` Jeff Liu
2013-12-13 13:04 ` Christoph Hellwig
2013-12-13 13:32 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB0C59.4070904@oracle.com \
--to=jeff.liu@oracle.com \
--cc=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox