Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support

Dave Chinner
2013-12-11T22:42:33Z

On Tue, Dec 10, 2013 at 11:46:57PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 10, 2013 at 12:11:57PM -0800, Junho Ryu wrote:
> > generic/225 runs fiemap. It would be nice to call
> > _require_xfs_io_fiemap like other tests which use fiemap.
>
> It's not exactly correct as it doesn't require xfs_io. If you have some
> spare cycles it would be good to factor out a _require_fiemap from it.

I'd just rename if _require_fiemap, because we need both xfs_io and
kernel support for it, and we need xfs_io support to check for
kernel support....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com