Re: [PATCH v3] xfs: free the efi AIL entry on log recovery failure

Mark Tinguely
2013-12-11T17:25:40Z

On 12/11/13 05:31, Christoph Hellwig wrote:
> Btw, I really think we need to get rid of abusing the AIL for
> tracking EFIs during log recovery before looking at the various
> leaks in this area. I've actually got a lightly tested patch for
> that, but didn't make much progress on that series. If you have
> and interest in that area and some spare QA cycles I'd recommend
> to base this on the patch below:
>
> ---
>> From b90935eaba9eb13c67101e5d723513bc6ca6e722 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig<hch@lst.de>
> Date: Sat, 23 Nov 2013 20:11:09 +0100
> Subject: [PATCH] xfs: simplify EFI/EFD recovery
>
> Use a cancellation table, similar to how we handle buffers instead of
> abusing the AIL during recovery.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
> fs/xfs/xfs_extfree_item.c | 8 +-
> fs/xfs/xfs_extfree_item.h | 6 --
> fs/xfs/xfs_log_priv.h | 1 +
> fs/xfs/xfs_log_recover.c | 183 +++++++++++++--------------------------------
> 4 files changed, 56 insertions(+), 142 deletions(-)

Good idea to remove EFI item recovery from the AIL. It may take some
time before I get to it.

--Mark.