From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 4/4] xfs: rename mem_to_page to xfs_bufmem_to_page
Date: Thu, 26 Dec 2013 18:44:24 +0800 [thread overview]
Message-ID: <52BC0888.3060702@oracle.com> (raw)
In-Reply-To: <20131226100825.GB11950@infradead.org>
On 12/26 2013 18:08 PM, Christoph Hellwig wrote:
> On Tue, Dec 24, 2013 at 08:48:47PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Rename mem_to_page() to xfs_bufmem_to_page() for XFS convention.
>
> There's nothing inherently buffere related in the function, it doesn't
> even take an argument related to buffers.
Well, I originally want to rename to xfs_buf_mem_to_page() by following
up other functions in this file with "xfs_buf_" prefix, something like
a typo...
Looks this routine can not be folded into xfs_buf_associate_memory()
without introducing another variable to hold the temporary type convert
value of pageaddr, so I'm fine if we remains the same.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-26 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 12:48 [PATCH 4/4] xfs: rename mem_to_page to xfs_bufmem_to_page Jeff Liu
2013-12-26 10:08 ` Christoph Hellwig
2013-12-26 10:44 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC0888.3060702@oracle.com \
--to=jeff.liu@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).