[PATCH 4/4] xfs: rename mem_to_page to xfs_bufmem_to_page

[PATCH 4/4] xfs: rename mem_to_page to xfs_bufmem_to_page

[Jeff Liu]

From: Jie Liu <jeff.liu@oracle.com>

Rename mem_to_page() to xfs_bufmem_to_page() for XFS convention.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 fs/xfs/xfs_buf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 544315e..286ddbe 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -732,8 +732,8 @@ xfs_buf_set_empty(
 }
 
 static inline struct page *
-mem_to_page(
-	void			*addr)
+xfs_bufmem_to_page(
+	void		*addr)
 {
 	if ((!is_vmalloc_addr(addr))) {
 		return virt_to_page(addr);
@@ -774,7 +774,7 @@ xfs_buf_associate_memory(
 	bp->b_offset = offset;
 
 	for (i = 0; i < bp->b_page_count; i++) {
-		bp->b_pages[i] = mem_to_page((void *)pageaddr);
+		bp->b_pages[i] = xfs_bufmem_to_page((void *)pageaddr);
 		pageaddr += PAGE_SIZE;
 	}
 
-- 
1.8.3.2

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 4/4] xfs: rename mem_to_page to xfs_bufmem_to_page

[Christoph Hellwig]

On Tue, Dec 24, 2013 at 08:48:47PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> Rename mem_to_page() to xfs_bufmem_to_page() for XFS convention.

There's nothing inherently buffere related in the function, it doesn't
even take an argument related to buffers.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 4/4] xfs: rename mem_to_page to xfs_bufmem_to_page

[Jeff Liu]

On 12/26 2013 18:08 PM, Christoph Hellwig wrote:
> On Tue, Dec 24, 2013 at 08:48:47PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Rename mem_to_page() to xfs_bufmem_to_page() for XFS convention.
> 
> There's nothing inherently buffere related in the function, it doesn't
> even take an argument related to buffers.
Well, I originally want to rename to xfs_buf_mem_to_page() by following
up other functions in this file with "xfs_buf_" prefix, something like
a typo...

Looks this routine can not be folded into xfs_buf_associate_memory()
without introducing another variable to hold the temporary type convert
value of pageaddr, so I'm fine if we remains the same.

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs