From: Mark Tinguely <tinguely@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/4] xfs: simplify xfs_ail_max
Date: Mon, 30 Dec 2013 09:07:24 -0600 [thread overview]
Message-ID: <52C18C2C.6090108@sgi.com> (raw)
In-Reply-To: <52B9829A.10804@oracle.com>
On 12/24/13 06:48, Jeff Liu wrote:
> From: Jie Liu<jeff.liu@oracle.com>
>
> We have already simplified xfs_ail_min() with a new list helper, i.e,
> list_first_entry_or_null(), but xfs_ail_max() still remains as same
> as there is no corresponding list helper we can use for now. It's
> fairly easy to simulate the list behavior of getting the last item
> in the AIL, therefore we can simplify xfs_ail_max() and move it to
> the header file to make this pair of AIL routines looks symmetrical.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> ---
> +/*
> + * Return a pointer to the last item in the AIL. If the AIL is empty, then
> + * return NULL.
> + */
> +static inline struct xfs_log_item *
> +xfs_ail_max(
> + struct xfs_ail *ailp)
> +{
> + return list_empty(&ailp->xa_ail) ? NULL :
> + list_last_entry(&ailp->xa_ail, struct xfs_log_item, li_ail);
> +}
> +
> +
> static inline void
> xfs_trans_ail_update(
> struct xfs_ail *ailp,
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-30 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 12:48 [PATCH 3/4] xfs: simplify xfs_ail_max Jeff Liu
2013-12-26 10:07 ` Christoph Hellwig
2013-12-26 10:52 ` Jeff Liu
2013-12-30 15:07 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C18C2C.6090108@sgi.com \
--to=tinguely@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).