From: Jeff Liu <jeff.liu@oracle.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 6/10] xfs: introduce xfs_bulkstat_ichunk_ra
Date: Tue, 31 Dec 2013 17:46:13 +0800 [thread overview]
Message-ID: <52C29265.8030701@oracle.com> (raw)
In-Reply-To: <52C1A5F7.2040604@sgi.com>
On 2013年12月31日 00:57, Mark Tinguely wrote:
> On 12/28/13 05:22, Jeff Liu wrote:
>> From: Jie Liu<jeff.liu@oracle.com>
>>
>> Introduce xfs_bulkstat_ichunk_ra() to loop over all clusters in
>> the next inode chunk, then performs readahead if there are any
>> allocated inodes in that cluster.
>>
>> Refactor xfs_bulkstat() with it.
>>
>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>> ---
>
> Had some problems applying this patch.
> ...
>
>> +STATIC void
>> +xfs_bulkstat_ichunk_ra(
>> + struct xfs_mount *mp,
>> + xfs_agnumber_t agno,
>> + struct xfs_inobt_rec_incore *irec)
>> +{
>> + xfs_agblock_t agbno;
>> + struct blk_plug plug;
>> + int blks_per_cluster;
>> + int inodes_per_cluster;
>> + int i; /* inode chunk index */
>> +
>> + agbno = XFS_AGINO_TO_AGBNO(mp, irec->ir_startino);
>> + blks_per_cluster = xfs_icluster_size_fsb(mp);
> ^^^^^
> does not exist.
This patch series is based on my previous code refactoring of
introducing xfs_icluster_size_fsb() helper. I guess you would
apply this patch on top of that without the current problems.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-31 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 11:22 [PATCH 6/10] xfs: introduce xfs_bulkstat_ichunk_ra Jeff Liu
2013-12-30 16:57 ` Mark Tinguely
2013-12-31 9:46 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C29265.8030701@oracle.com \
--to=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).