From: Jeff Liu <jeff.liu@oracle.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix off-by-one error in xfs_attr3_rmt_verify
Date: Tue, 07 Jan 2014 15:02:11 +0800 [thread overview]
Message-ID: <52CBA673.2090102@oracle.com> (raw)
In-Reply-To: <52CABFD1.70100@sgi.com>
On 01/06 2014 22:38 PM, Mark Tinguely wrote:
> On 01/01/14 05:28, Jeff Liu wrote:
>> From: Jie Liu<jeff.liu@oracle.com>
>>
>> With CRC check is enabled, if trying to set an attributes value just
>> equal to the maximum size of XATTR_SIZE_MAX would cause the v3 remote
>> attr write verification procedure failure, which would yield the back
>> trace like below:
>>
>> <snip>
>> XFS (sda7): Internal error xfs_attr3_rmt_write_verify at line 191 of
>> file fs/xfs/xfs_attr_remote.c
>> <snip>
>> Call Trace:
<snip>
>>
>> Tests:
>> setfattr -n user.longxattr -v `perl -e 'print "A"x65536'` testfile
>>
>> This patch fix it to check the remote EA size is greater than the
>> XATTR_SIZE_MAX rather than more than or equal to it, because it's
>> valid if the specified EA value size is equal to the limitation as
>> per VFS setxattr interface.
>>
>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>> ---
>
> Good catch. Are you making an edge case xfstest?
I plan to introduce a particular test case into generic subclass.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-01-07 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 11:28 [PATCH] xfs: fix off-by-one error in xfs_attr3_rmt_verify Jeff Liu
2014-01-06 14:38 ` Mark Tinguely
2014-01-07 7:02 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CBA673.2090102@oracle.com \
--to=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).