From: Jeff Liu <jeff.liu@oracle.com>
To: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs/io: set argmax to 1 for imap command
Date: Tue, 07 Jan 2014 15:28:25 +0800 [thread overview]
Message-ID: <52CBAC99.7020400@oracle.com> (raw)
In-Reply-To: <1389021866-10793-1-git-send-email-bfoster@redhat.com>
On 01/06 2014 23:24 PM, Brian Foster wrote:
> The imap command supports an optional argument to specify the
> number of inode records to capture per ioctl(), but argmax is
> currently set to 0. This leads to an error if an argument is
> provided on the command line. Set argmax to 1 to support the
> optional argument.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> io/imap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/imap.c b/io/imap.c
> index 0a4f14e..4f3f883 100644
> --- a/io/imap.c
> +++ b/io/imap.c
> @@ -67,7 +67,7 @@ imap_init(void)
> imap_cmd.name = "imap";
> imap_cmd.cfunc = imap_f;
> imap_cmd.argmin = 0;
> - imap_cmd.argmax = 0;
> + imap_cmd.argmax = 1;
> imap_cmd.args = _("[nentries]");
> imap_cmd.flags = CMD_NOMAP_OK;
> imap_cmd.oneline = _("inode map for filesystem of current file");
>
With this fix, the command behaviour is consistent with the help menu,
and the optional argument is useful to extend our test coverage.
Hence if no other objections, this patch looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-01-07 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 15:24 [PATCH] xfsprogs/io: set argmax to 1 for imap command Brian Foster
2014-01-07 7:28 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CBAC99.7020400@oracle.com \
--to=jeff.liu@oracle.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).