[PATCH] xfsprogs/io: set argmax to 1 for imap command

[PATCH] xfsprogs/io: set argmax to 1 for imap command

[Brian Foster]

The imap command supports an optional argument to specify the
number of inode records to capture per ioctl(), but argmax is
currently set to 0. This leads to an error if an argument is
provided on the command line. Set argmax to 1 to support the
optional argument.

Signed-off-by: Brian Foster <bfoster@redhat.com>
---
 io/imap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io/imap.c b/io/imap.c
index 0a4f14e..4f3f883 100644
--- a/io/imap.c
+++ b/io/imap.c
@@ -67,7 +67,7 @@ imap_init(void)
 	imap_cmd.name = "imap";
 	imap_cmd.cfunc = imap_f;
 	imap_cmd.argmin = 0;
-	imap_cmd.argmax = 0;
+	imap_cmd.argmax = 1;
 	imap_cmd.args = _("[nentries]");
 	imap_cmd.flags = CMD_NOMAP_OK;
 	imap_cmd.oneline = _("inode map for filesystem of current file");
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs/io: set argmax to 1 for imap command

[Jeff Liu]

On 01/06 2014 23:24 PM, Brian Foster wrote:
> The imap command supports an optional argument to specify the
> number of inode records to capture per ioctl(), but argmax is
> currently set to 0. This leads to an error if an argument is
> provided on the command line. Set argmax to 1 to support the
> optional argument.
> 
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
>  io/imap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/io/imap.c b/io/imap.c
> index 0a4f14e..4f3f883 100644
> --- a/io/imap.c
> +++ b/io/imap.c
> @@ -67,7 +67,7 @@ imap_init(void)
>  	imap_cmd.name = "imap";
>  	imap_cmd.cfunc = imap_f;
>  	imap_cmd.argmin = 0;
> -	imap_cmd.argmax = 0;
> +	imap_cmd.argmax = 1;
>  	imap_cmd.args = _("[nentries]");
>  	imap_cmd.flags = CMD_NOMAP_OK;
>  	imap_cmd.oneline = _("inode map for filesystem of current file");
> 
With this fix, the command behaviour is consistent with the help menu,
and the optional argument is useful to extend our test coverage.
Hence if no other objections, this patch looks good to me.

Reviewed-by: Jie Liu <jeff.liu@oracle.com>

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs