From: "Michael L. Semon" <mlsemon35@gmail.com>
To: Ben Myers <bpm@sgi.com>, Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: require 64-bit sector_t
Date: Thu, 09 Jan 2014 13:48:35 -0500 [thread overview]
Message-ID: <52CEEF03.7080407@gmail.com> (raw)
In-Reply-To: <20140109151903.GF1935@sgi.com>
On 01/09/2014 10:19 AM, Ben Myers wrote:
> On Mon, Dec 16, 2013 at 04:15:59PM -0600, Ben Myers wrote:
>> Hey Christoph,
>>
>> On Thu, Nov 14, 2013 at 08:46:03AM -0800, Christoph Hellwig wrote:
>>> Trying to support tiny disks only and saving a bit memory might have
>>> made sense on an SGI O2 15 years ago, but is pretty pointless today.
>>>
>>> Remove the rarely tested codepath that uses various smaller in-memory
>>> types to reduce our test matrix and make the codebase a little bit
>>> smaller and less complicated.
>>>
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> This looks ok to me. I'm not seeing much downside to removing the smaller
>> in-memory types.
>>
>> Reviewed-by: Ben Myers <bpm@sgi.com>
>
> Anyone else have an opinion on this one? I think its 3.14 material and I'd
> like to pull it in.
>
> Thanks,
> Ben
Either way is fine with me. I use CONFIG_LBDAF=n, but it isn't a make-or-break
kernel config option. Most issues I've seen in testing were solved by Jeff
Liu's patches. This part of the test matrix seemed okay, but if Christoph wants
to get rid of it, that's fine. The XFS support matrix is rather brutal...
Thanks!
Michael
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-01-09 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 16:46 [PATCH] xfs: require 64-bit sector_t Christoph Hellwig
2013-12-10 16:20 ` Christoph Hellwig
2014-06-16 14:47 ` Christoph Hellwig
2013-12-13 21:37 ` Ben Myers
2013-12-13 23:01 ` Ben Myers
2013-12-16 22:15 ` Ben Myers
2014-01-09 15:19 ` Ben Myers
2014-01-09 18:48 ` Michael L. Semon [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-16 16:44 Christoph Hellwig
2014-06-17 14:14 ` Brian Foster
2014-06-18 15:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CEEF03.7080407@gmail.com \
--to=mlsemon35@gmail.com \
--cc=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).