* [PATCH] xfs: use tr_growrtalloc for growing rt files
@ 2014-01-17 20:09 Brian Foster
2014-01-17 20:52 ` Eric Sandeen
2014-01-18 4:16 ` Jeff Liu
0 siblings, 2 replies; 3+ messages in thread
From: Brian Foster @ 2014-01-17 20:09 UTC (permalink / raw)
To: xfs
This is a regression from the following commit:
3d3c8b5222b9 xfs: refactor xfs_trans_reserve() interface
Use the tr_growrtalloc log reservation for growing the
bitmap/summary files.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
fs/xfs/xfs_rtalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index a6a76b2..ec5ca65 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -842,7 +842,7 @@ xfs_growfs_rt_alloc(
/*
* Reserve space & log for one extent added to the file.
*/
- error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growdata,
+ error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growrtalloc,
resblks, 0);
if (error)
goto error_cancel;
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: use tr_growrtalloc for growing rt files
2014-01-17 20:09 [PATCH] xfs: use tr_growrtalloc for growing rt files Brian Foster
@ 2014-01-17 20:52 ` Eric Sandeen
2014-01-18 4:16 ` Jeff Liu
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2014-01-17 20:52 UTC (permalink / raw)
To: Brian Foster, xfs
On 1/17/14, 2:09 PM, Brian Foster wrote:
> This is a regression from the following commit:
>
> 3d3c8b5222b9 xfs: refactor xfs_trans_reserve() interface
>
> Use the tr_growrtalloc log reservation for growing the
> bitmap/summary files.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks right to me. :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/xfs_rtalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index a6a76b2..ec5ca65 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -842,7 +842,7 @@ xfs_growfs_rt_alloc(
> /*
> * Reserve space & log for one extent added to the file.
> */
> - error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growdata,
> + error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growrtalloc,
> resblks, 0);
> if (error)
> goto error_cancel;
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: use tr_growrtalloc for growing rt files
2014-01-17 20:09 [PATCH] xfs: use tr_growrtalloc for growing rt files Brian Foster
2014-01-17 20:52 ` Eric Sandeen
@ 2014-01-18 4:16 ` Jeff Liu
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Liu @ 2014-01-18 4:16 UTC (permalink / raw)
To: Brian Foster, xfs
On 01/18 2014 04:09 AM, Brian Foster wrote:
> This is a regression from the following commit:
>
> 3d3c8b5222b9 xfs: refactor xfs_trans_reserve() interface
>
> Use the tr_growrtalloc log reservation for growing the
> bitmap/summary files.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> fs/xfs/xfs_rtalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index a6a76b2..ec5ca65 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -842,7 +842,7 @@ xfs_growfs_rt_alloc(
> /*
> * Reserve space & log for one extent added to the file.
> */
> - error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growdata,
> + error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growrtalloc,
> resblks, 0);
My previous mistake, thank you and Eric for catching up this.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-18 4:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-17 20:09 [PATCH] xfs: use tr_growrtalloc for growing rt files Brian Foster
2014-01-17 20:52 ` Eric Sandeen
2014-01-18 4:16 ` Jeff Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).