From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id A03F629E05 for ; Tue, 21 Jan 2014 22:45:06 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 7300A8F8065 for ; Tue, 21 Jan 2014 20:45:06 -0800 (PST) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id 20TNNfemz1GgpbHP (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 21 Jan 2014 20:45:05 -0800 (PST) Message-ID: <52DF4CCB.1050003@oracle.com> Date: Wed, 22 Jan 2014 12:44:59 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: Re: [PATCH v2] xfs: use tr_qm_dqalloc log reservation for dquot alloc References: <1390228140-49211-1-git-send-email-bfoster@redhat.com> In-Reply-To: <1390228140-49211-1-git-send-email-bfoster@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster , xfs@oss.sgi.com On 01/20 2014 22:29 PM, Brian Foster wrote: > The dquot allocation path in xfs_qm_dqread() currently uses the > attribute set log reservation, which appears to be incorrect. We > have reports of transaction reservation overruns with the current > code. E.g., a repeated run of xfstests test generic/270 on a 512b > block size fs occassionally produces the following in dmesg: > > XFS (sdN): xlog_write: reservation summary: > trans type = QM_DQALLOC (30) > unit res = 7080 bytes > current res = -632 bytes > total reg = 0 bytes (o/flow = 0 bytes) > ophdrs = 0 (ophdr space = 0 bytes) > ophdr + reg = 0 bytes > num regions = 0 > > XFS (sdN): xlog_write: reservation ran out. Need to up reservation > > The dquot allocation case should consist of a write reservation > (i.e., we are allocating a range of the internal quota file) plus > the size of the actual dquots. We already have a log reservation > definition for this operation (tr_qm_dqalloc). Use it in > xfs_qm_dqread() and update the log reservation calculation function > to use the write res. calculation function rather than reading the > assumed to be pre-calculated value directly. > > Signed-off-by: Brian Foster Reviewed-by: Jie Liu Thanks, -Jeff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs