[PATCH] xfs/199: enforce v4 superblock format for test

[PATCH] xfs/199: enforce v4 superblock format for test

[Dave Chinner]

From: Dave Chinner <dchinner@redhat.com>

This test relies of the contents of the sb_features2 field being
known. Make sure ot clear allt eh MKFS_OPTIONS and ensure that we
direct mkfs to create only the simplest of featuresets to test this
functionality.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/xfs/199 | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/199 b/tests/xfs/199
index 1d64e02..c1b5962 100755
--- a/tests/xfs/199
+++ b/tests/xfs/199
@@ -49,7 +49,10 @@ _supported_os Linux
 
 _require_scratch
 
-_scratch_mkfs_xfs -l lazy-count=1 >/dev/null 2>&1
+# clear any mkfs options so taht we can directly specify the options we need to
+# be able to test the features bitmask behaviour correctly.
+MKFS_OPTIONS=
+_scratch_mkfs_xfs -l lazy-count=1 -i projid32bit=0 >/dev/null 2>&1
 
 #
 # Print the current flags.  Just a dummy so that the test breaks
-- 
1.8.4.rc3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs/199: enforce v4 superblock format for test

[Jeff Liu]

On 01/21 2014 19:10 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> This test relies of the contents of the sb_features2 field being
> known. Make sure ot clear allt eh MKFS_OPTIONS and ensure that we
> direct mkfs to create only the simplest of featuresets to test this
> functionality.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
>  tests/xfs/199 | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/199 b/tests/xfs/199
> index 1d64e02..c1b5962 100755
> --- a/tests/xfs/199
> +++ b/tests/xfs/199
> @@ -49,7 +49,10 @@ _supported_os Linux
>  
>  _require_scratch
>  
> -_scratch_mkfs_xfs -l lazy-count=1 >/dev/null 2>&1
> +# clear any mkfs options so taht we can directly specify the options we need to
				^^^
				a typo...
> +# be able to test the features bitmask behaviour correctly.
> +MKFS_OPTIONS=
> +_scratch_mkfs_xfs -l lazy-count=1 -i projid32bit=0 >/dev/null 2>&1
>  
>  #
>  # Print the current flags.  Just a dummy so that the test breaks

Looks good to me.

Reviewed-by: Jie Liu <jeff.liu@oracle.com>


Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs