From: Eric Sandeen <sandeen@sandeen.net>
To: Koen De Wit <koen.de.wit@oracle.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: define $seqres in btrfs/026-029
Date: Wed, 22 Jan 2014 10:55:58 -0600 [thread overview]
Message-ID: <52DFF81E.3030802@sandeen.net> (raw)
In-Reply-To: <1390404738-387-1-git-send-email-koen.de.wit@oracle.com>
On 1/22/14, 9:32 AM, Koen De Wit wrote:
> I forgot to define $seqres in btrfs/026-029. As a result, a file named
> .full was created in the current working directory. Fix it.
> ---
> tests/btrfs/026 | 1 +
> tests/btrfs/027 | 1 +
> tests/btrfs/028 | 1 +
> tests/btrfs/029 | 1 +
> 4 files changed, 4 insertions(+), 0 deletions(-)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
presumably we can add your signed-off-by? ;)
I wonder if this can't be done in the common scripts:
# grep -h seqres= tests/*/??? | sort | uniq -c
349 seqres=$RESULT_DIR/$seq
rather than doing it in every single test ...
-Eric
>
> diff --git a/tests/btrfs/026 b/tests/btrfs/026
> index bf6f528..6c54590 100644
> --- a/tests/btrfs/026
> +++ b/tests/btrfs/026
> @@ -26,6 +26,7 @@
> #
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> diff --git a/tests/btrfs/027 b/tests/btrfs/027
> index d76bb0f..b2dff1c 100644
> --- a/tests/btrfs/027
> +++ b/tests/btrfs/027
> @@ -26,6 +26,7 @@
> #-----------------------------------------------------------------------
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> diff --git a/tests/btrfs/028 b/tests/btrfs/028
> index 06d2faf..f17f102 100644
> --- a/tests/btrfs/028
> +++ b/tests/btrfs/028
> @@ -24,6 +24,7 @@
> #-----------------------------------------------------------------------
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> diff --git a/tests/btrfs/029 b/tests/btrfs/029
> index 1fd2a93..b93b6df 100644
> --- a/tests/btrfs/029
> +++ b/tests/btrfs/029
> @@ -29,6 +29,7 @@
> #-----------------------------------------------------------------------
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-01-22 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 15:32 [PATCH] xfstests: define $seqres in btrfs/026-029 Koen De Wit
2014-01-22 16:55 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DFF81E.3030802@sandeen.net \
--to=sandeen@sandeen.net \
--cc=koen.de.wit@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).